* [PATCH] tst-socket-timestamp-compat.c: Check __TIMESIZE [BZ #28837]
@ 2022-01-29 13:29 H.J. Lu
2022-01-29 14:46 ` Adhemerval Zanella
0 siblings, 1 reply; 2+ messages in thread
From: H.J. Lu @ 2022-01-29 13:29 UTC (permalink / raw)
To: libc-alpha
time_t size is defined by __TIMESIZE, not __WORDSIZE. Check __TIMESIZE,
instead of __WORDSIZE, for time_t size. This fixes BZ #28837.
---
sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
index de261dae5a..0ff1a214e6 100644
--- a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
+++ b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
@@ -237,7 +237,7 @@ do_test (void)
{
/* This test only make sense for ABIs that support 32 bit time_t socket
timestampss. */
- if (sizeof (time_t) > 4 && __WORDSIZE == 64)
+ if (sizeof (time_t) > 4 && __TIMESIZE == 64)
return 0;
srv = xsocket (AF_INET, SOCK_DGRAM, 0);
--
2.34.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] tst-socket-timestamp-compat.c: Check __TIMESIZE [BZ #28837]
2022-01-29 13:29 [PATCH] tst-socket-timestamp-compat.c: Check __TIMESIZE [BZ #28837] H.J. Lu
@ 2022-01-29 14:46 ` Adhemerval Zanella
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2022-01-29 14:46 UTC (permalink / raw)
To: H.J. Lu, libc-alpha
On 29/01/2022 10:29, H.J. Lu wrote:
> time_t size is defined by __TIMESIZE, not __WORDSIZE. Check __TIMESIZE,
> instead of __WORDSIZE, for time_t size. This fixes BZ #28837.
LGTM, thanks for catching it.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
> index de261dae5a..0ff1a214e6 100644
> --- a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
> +++ b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c
> @@ -237,7 +237,7 @@ do_test (void)
> {
> /* This test only make sense for ABIs that support 32 bit time_t socket
> timestampss. */
> - if (sizeof (time_t) > 4 && __WORDSIZE == 64)
> + if (sizeof (time_t) > 4 && __TIMESIZE == 64)
> return 0;
>
> srv = xsocket (AF_INET, SOCK_DGRAM, 0);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-29 14:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-29 13:29 [PATCH] tst-socket-timestamp-compat.c: Check __TIMESIZE [BZ #28837] H.J. Lu
2022-01-29 14:46 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).