From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 7BC1A3858D28 for ; Sat, 29 Jan 2022 14:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7BC1A3858D28 Received: by mail-ot1-x333.google.com with SMTP id o9-20020a9d7189000000b0059ee49b4f0fso8557565otj.2 for ; Sat, 29 Jan 2022 06:46:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=BRIuBsafV7rdnEYTPNv7iM9eUrr2q3g/7mR9+J153kU=; b=kSzNEdvWJTTohQn/K+IOywVCCvkhRC3GO+Fz2eQ0GuIRh1L8RxrTvs3pU053Df+VfR pgEESD5r3WF6yYJh5xZBgZ6BFNbO+HdQeNG1yssvV/LYiEjgRjeKzNSR0nJn4Dny3ckF MceEBT05/BYQU/nVK4Qt4eI5ulweicjeBjfX7Jp7eedQt7IL27DaZGzjrXty9uqBW93e B06Rhu9x2wb3qsQIXFvcLqc/b7h28dlkkzx3zARrrFs5LzhkD664LTPf1SvfiDvuTKnr K97dLjZg0POoDMWDUQlsfxUwDiKL7QPkQSY44uxtIozdfVWBTiYuGFn6s2NVBlMi7mLQ 9Jaw== X-Gm-Message-State: AOAM530LzMqDN43C9ClAHSb5acx6BEbMICof1b87opMKhop052uFVKv2 KJekysHwGdWcQOmkNwaCKOHlkE7CCjalMA== X-Google-Smtp-Source: ABdhPJzWB0EgzWUfIig6NXEq5Y9l2wN3uuk1ktzNnK5vsGspo0lcbe6mKYfxrykyRmX/sjDkB9lhuQ== X-Received: by 2002:a9d:69c1:: with SMTP id v1mr7587217oto.134.1643467569833; Sat, 29 Jan 2022 06:46:09 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:2377:9ffd:b28:b816? ([2804:431:c7ca:709a:2377:9ffd:b28:b816]) by smtp.gmail.com with ESMTPSA id c22sm11720265oot.38.2022.01.29.06.46.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Jan 2022 06:46:09 -0800 (PST) Message-ID: <28fa7f49-895f-1390-8e04-f2d8e15a20c2@linaro.org> Date: Sat, 29 Jan 2022 11:46:07 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] tst-socket-timestamp-compat.c: Check __TIMESIZE [BZ #28837] Content-Language: en-US To: "H.J. Lu" , libc-alpha@sourceware.org References: <20220129132932.10564-1-hjl.tools@gmail.com> From: Adhemerval Zanella In-Reply-To: <20220129132932.10564-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Jan 2022 14:46:12 -0000 On 29/01/2022 10:29, H.J. Lu wrote: > time_t size is defined by __TIMESIZE, not __WORDSIZE. Check __TIMESIZE, > instead of __WORDSIZE, for time_t size. This fixes BZ #28837. LGTM, thanks for catching it. Reviewed-by: Adhemerval Zanella > --- > sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c > index de261dae5a..0ff1a214e6 100644 > --- a/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c > +++ b/sysdeps/unix/sysv/linux/tst-socket-timestamp-compat.c > @@ -237,7 +237,7 @@ do_test (void) > { > /* This test only make sense for ABIs that support 32 bit time_t socket > timestampss. */ > - if (sizeof (time_t) > 4 && __WORDSIZE == 64) > + if (sizeof (time_t) > 4 && __TIMESIZE == 64) > return 0; > > srv = xsocket (AF_INET, SOCK_DGRAM, 0);