From: Carlos O'Donell <carlos@redhat.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
libc-alpha@sourceware.org
Subject: Re: [PATCH 3/3] powerpc: Fix powerpc64 strchrnul build with old gcc
Date: Tue, 25 Jul 2023 22:40:57 -0400 [thread overview]
Message-ID: <290e2515-0b93-fb8d-7de7-6afec48c86f0@redhat.com> (raw)
In-Reply-To: <20230724171524.2687112-4-adhemerval.zanella@linaro.org>
On 7/24/23 13:15, Adhemerval Zanella via Libc-alpha wrote:
> The compiler might not see that internal definition is an alias
> due the libc_ifunc macro, which redefines __strchrnul. With
> gcc 6 it fails with:
>
> In file included from <command-line>:0:0:
> ./../include/libc-symbols.h:472:33: error: ‘__EI___strchrnul’ aliased to
> undefined symbol ‘__GI___strchrnul’
> extern thread __typeof (name) __EI_##name \
> ^
> ./../include/libc-symbols.h:468:3: note: in expansion of macro
> ‘__hidden_ver2’
> __hidden_ver2 (, local, internal, name)
> ^~~~~~~~~~~~~
> ./../include/libc-symbols.h:476:29: note: in expansion of macro
> ‘__hidden_ver1’
> # define hidden_def(name) __hidden_ver1(__GI_##name, name, name);
> ^~~~~~~~~~~~~
> ./../include/libc-symbols.h:557:32: note: in expansion of macro
> ‘hidden_def’
> # define libc_hidden_def(name) hidden_def (name)
> ^~~~~~~~~~
> ../sysdeps/powerpc/powerpc64/multiarch/strchrnul.c:38:1: note: in
> expansion of macro ‘libc_hidden_def’
> libc_hidden_def (__strchrnul)
> ^~~~~~~~~~~~~~~
>
> Use libc_ifunc_hidden as stpcpy. Checked on powerpc64 with
> gcc 6 and gcc 13.
Using the _hidden variant here is OK.
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
> ---
> sysdeps/powerpc/powerpc64/multiarch/strchrnul.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/sysdeps/powerpc/powerpc64/multiarch/strchrnul.c b/sysdeps/powerpc/powerpc64/multiarch/strchrnul.c
> index 94873507a6..87dd41f72d 100644
> --- a/sysdeps/powerpc/powerpc64/multiarch/strchrnul.c
> +++ b/sysdeps/powerpc/powerpc64/multiarch/strchrnul.c
> @@ -27,13 +27,13 @@ extern __typeof (__strchrnul) __strchrnul_power8 attribute_hidden;
>
> /* Avoid DWARF definition DIE on ifunc symbol so that GDB can handle
> ifunc symbol properly. */
> -libc_ifunc (__strchrnul,
> - (hwcap2 & PPC_FEATURE2_ARCH_2_07
> - && hwcap & PPC_FEATURE_HAS_ALTIVEC)
> - ? __strchrnul_power8 :
> - (hwcap & PPC_FEATURE_ARCH_2_06)
> - ? __strchrnul_power7
> - : __strchrnul_ppc);
> +libc_ifunc_hidden (__strchrnul, __strchrnul,
> + (hwcap2 & PPC_FEATURE2_ARCH_2_07
> + && hwcap & PPC_FEATURE_HAS_ALTIVEC)
> + ? __strchrnul_power8 :
> + (hwcap & PPC_FEATURE_ARCH_2_06)
> + ? __strchrnul_power7
> + : __strchrnul_ppc);
>
> libc_hidden_def (__strchrnul)
> weak_alias (__strchrnul, strchrnul)
--
Cheers,
Carlos.
next prev parent reply other threads:[~2023-07-26 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 17:15 [PATCH 0/3] Build fixes for older gcc Adhemerval Zanella
2023-07-24 17:15 ` [PATCH 1/3] malloc: Fix set-freeres.c with gcc 6 Adhemerval Zanella
2023-07-26 2:26 ` Carlos O'Donell
2023-07-24 17:15 ` [PATCH 2/3] sunrpc: Fix netname build with older gcc Adhemerval Zanella
2023-07-26 2:27 ` Carlos O'Donell
2023-07-24 17:15 ` [PATCH 3/3] powerpc: Fix powerpc64 strchrnul build with old gcc Adhemerval Zanella
2023-07-26 2:40 ` Carlos O'Donell [this message]
2023-07-25 20:06 ` [PATCH 0/3] Build fixes for older gcc Andreas K. Huettel
2023-07-25 20:38 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=290e2515-0b93-fb8d-7de7-6afec48c86f0@redhat.com \
--to=carlos@redhat.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).