From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 954993858D1E for ; Tue, 30 Jan 2024 00:28:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 954993858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 954993858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706574521; cv=none; b=ovkOAvewosFzweCJNNGNM7mwuhbcFf/k/6mKNpT4gkYGslS41OABVw9QU4r3DD5PdZkL8eUi9ulzx+0x+aqoNy8cuyj8r7JJFQLgSQAqYKFDtmkDwXbrQBB2g7YLO17r3BMJFnG0Pit7mcsek1RfokvFH/Ri0LLL/o2tCLqmltk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706574521; c=relaxed/simple; bh=IBuAhAEIy10EH/QYStsn+FxMGzoZX1Dn1RX/Te9PRoA=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=jQTDmoY6QIUs9UL+YCBjyySuvUQVyQTC9VEQYcD+pQCbNklIUVQnGAz3xA99cmO1ldornNVtjFN21Q3/HOb2+SNNlfGWPN6M4i/jv/er8xUDco2ww2GHuUH+Y8YPBAs6aT/dsxIjB+DDozDARr7pSyLDh6wBd9OMBlim3XZwBmw= ARC-Authentication-Results: i=1; server2.sourceware.org From: "Andreas K. Huettel" To: Joseph Myers , Jakub Jelinek Cc: libc-alpha@sourceware.org Subject: Re: [PATCH] v4: Use gcc __builtin_stdc_* builtins in stdbit.h if possible Date: Tue, 30 Jan 2024 01:28:31 +0100 Message-ID: <2953861.VdNmn5OnKV@pinacolada> Organization: Gentoo Linux In-Reply-To: References: <7bc9dd4-8e6c-a942-8394-e2c856bd8b6@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart2009044.PIDvDuAF1L"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --nextPart2009044.PIDvDuAF1L Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: "Andreas K. Huettel" Cc: libc-alpha@sourceware.org Date: Tue, 30 Jan 2024 01:28:31 +0100 Message-ID: <2953861.VdNmn5OnKV@pinacolada> Organization: Gentoo Linux In-Reply-To: MIME-Version: 1.0 Am Montag, 29. Januar 2024, 23:10:41 CET schrieb Jakub Jelinek: > On Mon, Jan 29, 2024 at 09:30:19PM +0000, Joseph Myers wrote: > > On Mon, 29 Jan 2024, Jakub Jelinek wrote: > >=20 > > > Most of the other tests (except the tests for side-effects in argumen= ts) > > > have constant arguments and so can be folded very early during compil= ation, > > > even the side-effects in arguments tests can be folded soon when opti= mizing, > > > so these functions were just an attempt to make sure the macros can be > > > compiled/linked when the arguments are certainly not known. > > > But if you think it isn't worth checking that or if it is already tes= ted by > > > some other test, I can remove that. > >=20 > > I think the existing tests adequately cover non-constant arguments=20 > > (non-constant unless you unroll the test loop and extract the arguments= =20 > > from a const array of structures then propagate from the variable stori= ng=20 > > them after loading from the array, that is). What the existing tests=20 > > don't actually cover for standard types (and this new test does cover) = is=20 > > constant arguments. >=20 > Ok, removed that part of the test. >=20 > > Note that as we're currently in release freeze for glibc 2.39, a new=20 > > feature change such as this should probably only go in before 2.39 is=20 > > released with the approval of Andreas K. H=FCttel as release manager (w= hile=20 > > if going in after 2.39 is released, the new feature of unsigned __int12= 8 /=20 > > unsigned _BitInt support should get a NEWS entry for 2.40). >=20 > Andreas, your thoughts on whether this can be added to 2.39 or needs to w= ait > for 2.40? It is an extension to a new feature (stdbit.h has been added on > 3rd of January) and doesn't have ABI consequences. Hi Jakub, let's please do this after the release (i.e. for 2.40).=20 I plan to branch tomorrow or wednesday, which means there is barely any time for wider testing anymore. Thanks! A =2D-=20 Andreas K. H=FCttel dilfridge@gentoo.org Gentoo Linux developer (council, toolchain, base-system, perl, libreoffice) --nextPart2009044.PIDvDuAF1L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAABCgB9FiEE/Rnm0xsZLuTcY+rT3CsWIV7VQSoFAmW4QrBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZE MTlFNkQzMUIxOTJFRTREQzYzRUFEM0RDMkIxNjIxNUVENTQxMkEACgkQ3CsWIV7V QSrz7g/+NgJoFP1EWGmO6UYOPfib75D8RJ2nFpcYZZKoUAG/tZKSAynij7Mp9hB5 O0ACvP1qiiJOvytkePAKbGynF52BPogbyDyLrtLd/Ufmbg5BHHml5tk2Y00EISuM gLWwZmjVdSo4eosuaHKExLBiMHVijY65f5oHc+UMdVUnKjiFG0M1qVOeadkOaKL/ vLHFwowLOxFchqT50C3aHmLySFx/br6vboiTT9zCXMeVL5hTZTOVtSZsPxwht1C0 +nHGvYpGOi0yCsc7yas5lbENBzbz1cPttSg3xht0XQLD8OgBfNov4TYr2hkeOxZT eROj4lxjRDtoTCqnD/9YsJUGFqrNk4/duCUIR0RB/BWVmzE0x2DIIu/R+cZdOwF+ 7kcgY0IbukwjpG4/4vizpCqNakgSwKxxwYJtgX38MJnitAchXoIdDnnwWzmDFPc+ dC58e4UXZxezqlo2ENr04cbMeG4T0zxOzfdC4tknRGEcNNp5/uP36Ekbhzj/vdQr TlWEm4zStE0TivhWNJOwyDFpdWx6fDmCyNWHjWWvEbCU+xfGI1R1e36t61H58M7A cwK8AjG88iUNHg8+TVLXKERKW9xqIejMN9AjMF4SOrDEizvObAa8my26njd4/RFT U4T0VSdrBn6JZV+hjpam2mx4HTI3ITfRtYeIHOnSGBq48lQV0e8= =CiMJ -----END PGP SIGNATURE----- --nextPart2009044.PIDvDuAF1L--