From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-xa33.google.com (mail-vk1-xa33.google.com [IPv6:2607:f8b0:4864:20::a33]) by sourceware.org (Postfix) with ESMTPS id 2FEC83858D35 for ; Fri, 10 Dec 2021 13:13:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2FEC83858D35 Received: by mail-vk1-xa33.google.com with SMTP id 70so5966276vkx.7 for ; Fri, 10 Dec 2021 05:13:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=xbpfFjmEfxssHu+Woi5tte3DuH1CnIywKA694wbQGA0=; b=r0+I9ZedTitDkmML74RcGX8TcKXfRfEIXAMZJl/DvfnGgqBevyx2B8pSXo1H7go9/Z vxWbKEhH2PinXbum1I+situzwX8wVvSuaO6jxCaISBt0X7+d+xDltrs1AAZ6K6k2Wyll usq1CXzS/UHTZF5U7jVzdzBDZhljB7NWBfcXAMZJJAHMlY0riNz83MHNmz1MOaZ9B8Lo S6PtwKk6R9sAo6CVl3S0eRrdXywDc+/ZulSkluN2qop1B/eN9iqfTDgzw84wL/5/tTTg Gn6DEucZXYNgZ0tSGsnfUU14T/MjKzTV2aBREsiKR8iY96okmHtA9simZdJh4p5Nm71p C7EQ== X-Gm-Message-State: AOAM5333pZinMdCeOZV2dKaz0KscMGmRNjhl6bDUF1bmOfHNdqHwDX0t NZ6weVQGS6tvt1ZXB0OZP2FSrg== X-Google-Smtp-Source: ABdhPJyKOijsPEqhoPDytZ5Qs7VykuuGAwO2unkfhfVdYTtNgf2V2N/LN/Tba2PrGEUxRXbirvQDjw== X-Received: by 2002:a05:6122:178b:: with SMTP id o11mr18957693vkf.17.1639142021710; Fri, 10 Dec 2021 05:13:41 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:a776:ce11:d591:8bd5:613f? ([2804:431:c7ca:a776:ce11:d591:8bd5:613f]) by smtp.gmail.com with ESMTPSA id y22sm1792031vsy.33.2021.12.10.05.13.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Dec 2021 05:13:41 -0800 (PST) Message-ID: <297f0df8-c38c-996f-c3f4-f532f24ecff2@linaro.org> Date: Fri, 10 Dec 2021 10:13:39 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v2 2/2] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ #28350) Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha References: <20210929140619.279302-1-adhemerval.zanella@linaro.org> <20210929140619.279302-2-adhemerval.zanella@linaro.org> <878rwsbrri.fsf@oldenburg.str.redhat.com> <32567bed-9014-3db5-371a-56d4a8420966@linaro.org> <87zgp88vpm.fsf@oldenburg.str.redhat.com> <87v8zw8vl7.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87v8zw8vl7.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2021 13:13:44 -0000 On 10/12/2021 09:59, Florian Weimer wrote: > * Florian Weimer: > >> * Adhemerval Zanella: >> >>> Indeed I think it should be safe to drop the check, we already check >>> if before with CMSG_SPACE and return MSG_CTRUNC if this is no extra >>> space (which will make CMSG_NXTHDR return NULL). >>> >>> Are you ok with this change? >> >> Let me read it again … > > I don't see how we patch anything if CMSG_NEXT (msg, last) is null. The issue is the 'last = cmsg' not being updated for 'cmsg->cmsg_level != SOL_SOCKET'.