From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35797 invoked by alias); 12 Sep 2017 14:22:02 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 35762 invoked by uid 89); 12 Sep 2017 14:22:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:f8db X-HELO: mail-qk0-f172.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=OFIHpIQUCp+4ceky0a+il4exb6JeYjcI6aqmQ26ueYU=; b=Kh3rpRmah8COO0Yi3n9dlBfd4zJOoR7fCgybB+f1/SvXoYkEZxAQwQTZvnOKev8YLZ +LwdbZ6WAUvOUyqCiN7bKi8if8s3QgXGjp9slVvYxPWIS4yJ3W3VkIJftw/8Vaq8a/vv vOdQkONXdGodtrFqSha7QNsvngl44vYKJFhdtaYAMMA4SZ936yrDbjTmYEOKD+76FuBk Pj3B3Pqj/kfoD711ZiJEpxxbRR9cvNjrISWHyq3jwr2+vj+eejDsZMrRfhhfYg3T2u7d U3tssQ+ZBUP/KmaK3GKgRplDv6i1SGPBNtA/pZdL5VdWWC2ueGYoRpNYBZ3szPjTXuKi G2wg== X-Gm-Message-State: AHPjjUh2qZoXsFjLBh0nF2psnmTjHZuTXyOCfPCSjKsNlP3PA5EHn046 q9Gc7dKNoDrndA8u X-Google-Smtp-Source: AOwi7QDPShv0J6j/canYGtj79pv31wNqMugQgtyR2j9RkT8Zjhjcap6oLZC77e5JbmkARAjYN8lPgA== X-Received: by 10.55.54.12 with SMTP id d12mr18734467qka.20.1505226119091; Tue, 12 Sep 2017 07:21:59 -0700 (PDT) Subject: Re: [PATCH 7/9] posix: Consolidate glob implementation To: Andreas Schwab Cc: libc-alpha@sourceware.org, Paul Eggert References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-8-git-send-email-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <29c0bb72-189f-f8db-328e-05b9cdd84261@linaro.org> Date: Tue, 12 Sep 2017 14:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00502.txt.bz2 On 12/09/2017 09:56, Andreas Schwab wrote: > On Sep 05 2017, Adhemerval Zanella wrote: > >> diff --git a/sysdeps/unix/sysv/linux/oldglob.c b/sysdeps/unix/sysv/linux/oldglob.c >> index 8233e57..5402450 100644 >> --- a/sysdeps/unix/sysv/linux/oldglob.c >> +++ b/sysdeps/unix/sysv/linux/oldglob.c >> @@ -1,12 +1,13 @@ >> #include >> >> -#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2) >> +#if SHLIB_COMPAT(libc, GLIBC_2_1, GLIBC_2_2) \ >> + && !defined(GLOB_NO_OLD_VERSION) > > There is nothing that defines GLOB_NO_OLD_VERSION for s390-32. > > Andreas. > Yes, this is wrong since oldglob.c as default will create symbol where for s390 it should not. S390 requires a arch-specific oldglob.c as #define GLOB_NO_OLD_VERSION #include So glob64.os will the only object providing glob64 symbols. With this file now I see: $ /s390x-glibc-linux-gnu-objdump -t posix/glob64.os | grep glob64 posix/glob64.os: file format elf32-s390 000009b0 g F .text 0000144e __glob64 000009b0 g F .text 0000144e .hidden __GI_glob64 000009b0 g F .text 0000144e glob64 $ s390x-glibc-linux-gnu-objdump -t posix/oldglob.os | grep glob64 $ I will fix it and maybe it is confusing the linker and making you seem the missing glob64 (since oldglob.os and glob64.os both provide the same symbol).