From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 0F4233858D1E for ; Wed, 17 May 2023 22:09:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F4233858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=linux.vnet.ibm.com Received: from pps.filterd (m0353723.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34HLcsDD007625 for ; Wed, 17 May 2023 22:09:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=aKWscReiDw1olhy3RFSfW1a9fZEWx2vXL22SP0wz9C0=; b=GVnuaNygjGbAtWM2toXA53/zrupCBCK2D7aVheKN1mKQ2arXEfIekd3EUpZraoNHy5vm dxx8L4Y/zCses18miniR4ExOnT2TccV8sJWXp3NrnBptyE2ctrrF8wtfUPCi8Ub1fOZH AwHBnvDirhx8R18cq46CSCz+EW1OjBUXZC+Lf9tuxX6UrktGtzJEKjs2cu/cMwEy0wXa JBo4Raf7+oM30z/+GWcfaecWzdnn5l8eGNirsBQlLHH5tQTsVu4COlcIHDkflXED5Ar/ Sv6VemxCd7T4O1rCI8NwzuJANBruMMJMYvk9fPXE9zS63Sh6AFaRjC5+RZ2b9rGF6FdC AA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qn5fwb6r2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 17 May 2023 22:09:43 +0000 Received: from m0353723.ppops.net (m0353723.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 34HM8dNA029040 for ; Wed, 17 May 2023 22:09:12 GMT Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3qn5fwb53s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 22:09:12 +0000 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 34HJTDbC017939; Wed, 17 May 2023 22:08:49 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma01wdc.us.ibm.com (PPS) with ESMTPS id 3qj265fc8m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 17 May 2023 22:08:49 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 34HM8j9f63308260 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 17 May 2023 22:08:45 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 82BE558050; Wed, 17 May 2023 22:08:45 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BF7258045; Wed, 17 May 2023 22:08:45 +0000 (GMT) Received: from [9.61.43.34] (unknown [9.61.43.34]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 17 May 2023 22:08:45 +0000 (GMT) Message-ID: <29c3a1b5-af9a-1ada-b60e-64d4bfd9a797@linux.vnet.ibm.com> Date: Wed, 17 May 2023 17:08:44 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH] powerpc:GCC(<10) doesn't allow -mlong-double-64 after -mabi=ieeelongdouble Content-Language: en-US To: MAHESH BODAPATI , Florian Weimer Cc: MAHESH BODAPATI via Libc-alpha , rajis@linux.ibm.com, Mahesh Bodapati References: <20230512102259.2329923-1-bmahi496@linux.ibm.com> <87353x91wj.fsf@oldenburg.str.redhat.com> <87lehp75x0.fsf@oldenburg.str.redhat.com> <49298254-1d5c-2ae8-76cd-6d8ba64a22f0@linux.ibm.com> From: Rajalakshmi Srinivasaraghavan In-Reply-To: <49298254-1d5c-2ae8-76cd-6d8ba64a22f0@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: BPbuQeOSA9-b6HzTV2dkSUSwChXIxpi8 X-Proofpoint-GUID: Y_p5HH5IfZFioZ64V8VUjQtvBw8bQmLC X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-05-17_04,2023-05-17_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxscore=0 malwarescore=0 clxscore=1015 suspectscore=0 lowpriorityscore=0 adultscore=0 phishscore=0 impostorscore=0 bulkscore=0 mlxlogscore=837 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305170182 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/16/23 2:48 AM, MAHESH BODAPATI wrote: > > On 16/05/23 12:56 am, Florian Weimer wrote: >> * MAHESH BODAPATI: >> >>> On 15/05/23 6:39 pm, Florian Weimer wrote: >>>> * MAHESH BODAPATI via Libc-alpha: >>>> >>>>> From: Mahesh Bodapati >>>>> >>>>> Removed -mabi=ieeelongdouble on failing tests. It resolves the error. >>>>> error: ‘-mabi=ieeelongdouble’ requires ‘-mlong-double-128’ >>>> I think this is only need if GCC defaults to -mabi=ieeelongdouble, and >>>> GCC 10 is not ready for that for different reasons? >>> Yes,these tests are under "sysdeps/ieee754/ldbl-opt" and ieee754 >>> defaults to -mabi=ieeelongdouble and the >>> >>> CFLAGS were appended with -mlong-double-64 in commit >>> dee2bea048b688b643a9a ,but powerpc gcc (<10) >>> >>> doesn't support mabi=ieeelongdouble with -mlong-double-64.the support >>> has been addedin gcc 12.1 and >>> >>> it has been back-ported till gcc 10 so we are filtering out the >>> -mabi=ieelongdouble to make it work >> I think if you backport this stuff to GCC 10, you should also pick up >> the commit that fixed GCC.  I believe its commit cb16bc3b5f34733ef9bb >> ("rs6000: Allow -mlong-double-64 after -mabi={ibm,ieee}longdouble >> [PR104208, P R87496]"). > > Yes,that's the commit. we planned to switch the flags with respect to > GCC version but I don't see a existing mechanism for switching the > CFLAGS based on the target and GCC version so > > we are filtering out the flag "-mabi=ieeelongdouble" to make it work > on all the PowerPC GCC versions. LGTM.  This should help to fix CI build issues with older compilers. > >> >> Thanks, >> Florian >>