Re: [PATCH v5 01/14] ARC: ABI Implementation

[Vineet Gupta <Vineet.Gupta1@synopsys.com>]

On 4/17/20 3:37 PM, Joseph Myers wrote:
> On Wed, 8 Apr 2020, Vineet Gupta via Libc-alpha wrote:
> 
>> +#define reloc_index						\
>> +({								\
>> +  unsigned long int plt0 = D_PTR (l, l_info[DT_PLTGOT]);	\
>> +  unsigned long int pltn = reloc_arg;				\
>> +  /* Exclude PLT0 and PLT1.  */					\
>> +  unsigned long int idx = ((pltn - plt0) / 16 ) - 2;		\
> 
> There's a stray space between '16' and ')' here.

Fixed.


>> +/* Helper for generic ____longjmp_chk().  */
>> +#define JB_FRAME_ADDRESS(buf) ((void *) (unsigned long int) (buf[JB_SP]))
> 
> This comment should not use '()' (see the GNU Coding Standards, '()' 
> should not be appended to a function name to indicate that it's a 
> function, only to indicate a function call with no arguments).

Fixed.


>> +  __mcount_internal ((unsigned long int) frompc,			\
>> +		     (unsigned long int) __builtin_return_address(0));	\
> 
> Missing space before '(' in call to __builtin_return_address.

Fixed.


>> +#define TLS_LE(x)					\
>> +  ({ int *__result;					\
>> +     void *tp = __builtin_thread_pointer();		\
>> +     __asm__ ("add %0, %1, @" #x "@tpoff   \n"		\
>> +	  : "=r" (__result) : "r"(tp));	        	\
>> +     __result; })
>> +
>> +#define TLS_IE(x)					\
>> +  ({ int *__result;					\
>> +     void *tp = __builtin_thread_pointer();		\
>> +     __asm__ ("ld %0, [pcl, @" #x "@tlsie]      \n"     \
>> +	  "add %0, %1, %0                       \n"	\
>> +	  : "=&r" (__result) : "r" (tp));		\
>> +     __result; })
> 
> Missing spaces before '(' in calls to __builtin_thread_pointer.

Fixed.