From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: nd <nd@arm.com>
Subject: Re: [PATCH 6/6] Remove slow paths from sin/cos
Date: Tue, 13 Mar 2018 08:46:00 -0000 [thread overview]
Message-ID: <2a4f8559-9978-42ee-2b8a-df5d7335b425@gotplt.org> (raw)
In-Reply-To: <DB6PR0801MB2053545D642D5198FFBC730183D30@DB6PR0801MB2053.eurprd08.prod.outlook.com>
On Monday 12 March 2018 11:01 PM, Wilco Dijkstra wrote:
> I had lots of issues due to parts of functions being included in sincos.c, so I had to
> disable sincos during development. The new version is much easier to maintain.
That's subjective; someone half a decade down the line might differ when
they see bits of code duplicated across files :)
> This patch on its own gives a 16-20% speedup between 0 and 8*PI (this speedup
> continues up to 2^27). The overall speedup of sincos is 48% over this range, and
> between 0 and PI it is 66% faster. So I'd say specializing the small cases in sincos
> gives a significant gain.
That's a good rationale, please include it in your commit log.
Siddhesh
next prev parent reply other threads:[~2018-03-13 8:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 15:53 Wilco Dijkstra
2018-03-09 16:02 ` Siddhesh Poyarekar
2018-03-12 17:31 ` Wilco Dijkstra
2018-03-13 8:46 ` Siddhesh Poyarekar [this message]
2018-03-13 15:29 ` Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4f8559-9978-42ee-2b8a-df5d7335b425@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=nd@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).