From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fw@deneb.enyo.de>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v2 6/7] login: Use 64-bit time on struct lastlog
Date: Wed, 5 Aug 2020 17:36:30 -0300 [thread overview]
Message-ID: <2a7fa1bd-e801-ca9f-af3e-f06dc21a1da7@linaro.org> (raw)
In-Reply-To: <87a6z8c1ey.fsf@mid.deneb.enyo.de>
On 05/08/2020 16:56, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> diff --git a/bits/types/struct_lastlog.h b/bits/types/struct_lastlog.h
>> index 67ffec1b08..9e8983b57d 100644
>> --- a/bits/types/struct_lastlog.h
>> +++ b/bits/types/struct_lastlog.h
>> @@ -24,11 +24,11 @@
>> previous logins. */
>> struct lastlog
>> {
>> -#if __WORDSIZE_TIME64_COMPAT32
>> - int32_t ll_time;
>> +#if __WORDSIZE == 32
>> + int64_t ll_time;
>> #else
>> __time_t ll_time;
>> #endif
>
> Should this check for __TIMESIZE instead of __WORDSIZE? It shouldn't
> make a difference; I just think it would be clearer.
>
> Or maybe use int64_t unconditionally? That would be simpler.
>
The lastlog is not really defined in any standard, so I guess we have
this liberty here. I agree that int64_t unconditionally is simpler.
next prev parent reply other threads:[~2020-08-05 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 18:59 [PATCH v2 1/7] login: Move gnu utmpx to default implementation Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 2/7] Consolidate and simplify internal utmp definitions Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 3/7] support: Add 'touch' command Adhemerval Zanella
2020-08-05 19:08 ` DJ Delorie
2020-08-05 18:59 ` [PATCH v2 4/7] login: Add 64-bit time support to utmp/utmpx Adhemerval Zanella
2020-08-05 19:28 ` Joseph Myers
2020-08-05 20:35 ` Adhemerval Zanella
2020-08-05 20:43 ` Joseph Myers
2020-08-05 20:54 ` Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 5/7] linux: Add pwrite64_nocancel Adhemerval Zanella
2020-08-05 18:59 ` [PATCH v2 6/7] login: Use 64-bit time on struct lastlog Adhemerval Zanella
2020-08-05 19:56 ` Florian Weimer
2020-08-05 20:36 ` Adhemerval Zanella [this message]
2020-08-05 18:59 ` [PATCH v2 7/7] Remove __WORDSIZE_TIME64_COMPAT32 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a7fa1bd-e801-ca9f-af3e-f06dc21a1da7@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fw@deneb.enyo.de \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).