From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bumble.birch.relay.mailchannels.net (bumble.birch.relay.mailchannels.net [23.83.209.25]) by sourceware.org (Postfix) with ESMTPS id B6E853858036 for ; Wed, 6 Apr 2022 06:08:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B6E853858036 X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 54511C0AEF; Wed, 6 Apr 2022 06:08:16 +0000 (UTC) Received: from pdx1-sub0-mail-a307.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id F0F54C0AAE; Wed, 6 Apr 2022 06:08:15 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1649225296; a=rsa-sha256; cv=none; b=YlfQ8T6XPLAAaetu2CErS1i1StjXsSNikxLcWfE54Hl3U3H6ORn3AZhkZW+LEHJymgHcxk Sik6TczCeAETozLE0Qwewn+0L9w17Dd3UnuJ1KH7igxZ+c6I6sctQB3koGWrnc5YrSIsF9 3H7fE5s88XlltlY2sR2cViPqesrzgLZC90kJyk04fHJQWqp1Zq2LUZ5jAKlKaWgU0Wfxos 5RYEZvwNi+RUt++Vv/S2a0N1wX1CeivAOkT0/LdeR2Rmwjy1MSsnUw7AB+r9ANsvwf8rkf xfq+VY5TO2NgulK7lv2H13NblhLhkyUM0BUJfMsh5jVuSGVb2XDylr2b0gpCww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1649225296; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D/wTTAc8L2xLhVvv0fe9BlMvVbdIBML+NF7lcoc0TYQ=; b=1oqp4SRwekc/sT26Vbch0GGTEVhqeV3ocNNDyEqoNLZZYqrn1JE7F+OaVrID4G6QJn6I+6 6NU2ZsMEpV5pf1Gmt/8VgmDIUCFAQXc5Cf5w9z4SoDvlcP7pS0Mo3lpCgXSDD+BpjyJ4DS eEMwcL/n4zdFc3HkWX3HvOuqwF7ZJzF8/NKtIrCTaPVpvl17+0qUXrFI3MasUjC2oFDy5f S/Otkk3iPP5eXkMoSh+wp01hQu5WXXbXnO8AXxCSek6qOtjzGXIbg8CrgH0pqh8pQD90HA yT3bGb7VZW+APm4pMtIGPkUlnuWxIeQDxxlRBN9tY4wnGcbr9gNhdQgFijspFQ== ARC-Authentication-Results: i=1; rspamd-f76767c84-vg85j; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@sourceware.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a307.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.95.91 (trex/6.7.1); Wed, 06 Apr 2022 06:08:16 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Wipe-Bitter: 34c59d2b17e154ad_1649225296214_3086296330 X-MC-Loop-Signature: 1649225296214:853095212 X-MC-Ingress-Time: 1649225296214 Received: from [100.96.149.178] (unknown [49.248.235.144]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a307.dreamhost.com (Postfix) with ESMTPSA id 4KYDb26Nxcz3N; Tue, 5 Apr 2022 23:08:14 -0700 (PDT) Message-ID: <2aded52c-c84a-92d4-0fe8-96a9894101ac@sourceware.org> Date: Wed, 6 Apr 2022 11:38:11 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] tests/string: Drop simple/stupid/builtin tests Content-Language: en-US To: Noah Goldstein Cc: GNU C Library References: <20220405050501.39309-1-siddhesh@sourceware.org> From: Siddhesh Poyarekar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1164.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_NONE, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Apr 2022 06:08:19 -0000 On 06/04/2022 01:58, Noah Goldstein wrote: > On Tue, Apr 5, 2022 at 12:05 AM Siddhesh Poyarekar via Libc-alpha > wrote: >> >> In most cases the simple/stupid/builtin functions were in there to >> benchmark optimized implementations against. Only in some cases the >> functions are used to check expected results. >> >> Remove these tests from IMPL() and only keep them in wherever they're >> used for a specific purpose, e.g. to generate expected results. >> >> This improves timing of `make subdirs=string` by over a minute and a >> half (over 15%) on a Whiskey Lake laptop. > > Makes sense, although I would prefer if we kept the simple* functions > and just removed them from the test list. > > When adding new tests it's nice to have a guaranteed reference > to test the test... > > What do you think? I don't feel too strongly either way, I'll send v2 with in-test variants retained where none exists so that they may be used in future if need arises. Thanks, Siddhesh