From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v2] <time.h>: Make strptime available by default
Date: Thu, 8 Dec 2022 14:13:01 -0300 [thread overview]
Message-ID: <2af38d17-f641-d36a-b090-a3e00f8cd14e@linaro.org> (raw)
In-Reply-To: <87cz97rv5u.fsf@oldenburg.str.redhat.com>
On 28/11/22 11:49, Florian Weimer via Libc-alpha wrote:
> This matches what FreeBSD does.
>
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
> ---
> v2: Remove unneccesary parentheses.
> time/time.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/time/time.h b/time/time.h
> index d18089116e..0919e578d4 100644
> --- a/time/time.h
> +++ b/time/time.h
> @@ -101,7 +101,7 @@ extern size_t strftime (char *__restrict __s, size_t __maxsize,
> const char *__restrict __format,
> const struct tm *__restrict __tp) __THROW;
>
> -#ifdef __USE_XOPEN
> +#if defined __USE_XOPEN || defined __USE_MISC
> /* Parse S according to FORMAT and store binary time information in TP.
> The return value is a pointer to the first unparsed character in S. */
> extern char *strptime (const char *__restrict __s,
>
> base-commit: f704192911c6c7b65a54beab3ab369fca7609a5d
>
next prev parent reply other threads:[~2022-12-08 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-28 14:49 Florian Weimer
2022-12-08 17:13 ` Adhemerval Zanella Netto [this message]
2022-12-08 18:13 ` Florian Weimer
2022-12-08 18:24 ` Adhemerval Zanella Netto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2af38d17-f641-d36a-b090-a3e00f8cd14e@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).