Re: [PATCH 2/8] Consolidate Linux open implementation

[Adhemerval Zanella <adhemerval.zanella@linaro.org>]

On 15/05/2017 09:47, Tulio Magno Quites Machado Filho wrote:
> Adhemerval Zanella <adhemerval.zanella@linaro.org> writes:
> 
>> This patch consolidates the open Linux syscall implementation on
>> sysdeps/unix/sysv/linux/open{64}.c.  The changes are:
>>
>>   1. Remove open{64} from auto-generation syscalls.list.
>>   2. Add a new open{64}.c implementation.  For architectures that
>>      define __OFF_T_MATCHES_OFF64_T the default open64 will create
>>      alias to required open symbols.
>>   3. Use __NR_open where possible, otherwise use __NR_openat.
>>
>> Checked on i686-linux-gnu, x86_64-linux-gnu, x86_64-linux-gnux32,
>> arch64-linux-gnu, arm-linux-gnueabihf, and powerpc64le-linux-gnu.
>>
>> 	* sysdeps/unix/sysv/linux/generic/open.c: Remove file.
>> 	* sysdeps/unix/sysv/linux/generic/open64.c: Likewise.
>> 	* sysdeps/unix/sysv/linux/wordsize-64/open64.c: Likewise.
>> 	* sysdeps/unix/sysv/linux/open.c: New file.
>> 	* sysdeps/unix/sysv/linux/open64.c (__libc_open64): Use O_LARGEFILE
>> 	only for __OFF_T_MATCHES_OFF64_T and add alias to open if the case.
>> 	* sysdeps/unix/sysv/linux/wordsize-64/syscalls.list: Remove open
>> 	from auto-generated list.
> 
> For the record: there was a build error in our POWER8 BuildSlave right after
> this patch was merged [1].
> 
> I was not able to reproduce this error on my servers and I suspect it might
> be related to issues in our BuildBot setup which may still be leaving
> old files before starting a new build.
> 
> This patch is not related to the failures on build 464 on the same builder.
> 
> [1] http://144.217.14.79/builders/glibc-power8-linux/builds/463
> 

It is unexpected because I did checked natively on powerpc64le-linux-gnu
(power8) and also on cross-compiling using build-many-glibc.py.