From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: YunQiang Su <syq@debian.org>
Cc: libc-alpha@sourceware.org, Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH] linux: Alias non-LFS to LFS stat function for mips and sparc (BZ #29730)
Date: Mon, 31 Oct 2022 14:22:04 -0300 [thread overview]
Message-ID: <2b020cd8-98e7-fea0-6cb8-9e33fe955538@linaro.org> (raw)
In-Reply-To: <CAKcpw6Xz_A03=dS4J3h=SBOhmVV7==vJ=MNDE7-JdGN2HP-oTA@mail.gmail.com>
On 31/10/22 14:07, YunQiang Su wrote:
>> --- a/sysdeps/unix/sysv/linux/mips/kernel_stat.h
>> +++ b/sysdeps/unix/sysv/linux/mips/kernel_stat.h
>> @@ -63,8 +63,10 @@ struct kernel_stat
>> #define STAT64_IS_KERNEL_STAT64 0
>> #define XSTAT_IS_XSTAT64 0
>> #if _MIPS_SIM == _ABI64
>> +# define STAT_IS_STAT64 1
>
> No. It is not correct.
> The reason of that we cannot use STAT_IS_STAT64 for MIPS N64 is that:
> struct stat
> struct stat64
> are different in their internal padding.
> So to keep binary compatible, we cannot use STAT_IS_STAT64.
>
> Not due to the quirk struct kernel_stat.
> In fact we can workaround this problem with statx.
Yeah, I did not checked correctly and st_size does indeed have different
offsets.
prev parent reply other threads:[~2022-10-31 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 16:00 Adhemerval Zanella
2022-10-31 16:58 ` Joseph Myers
2022-10-31 17:21 ` Adhemerval Zanella Netto
2022-10-31 17:07 ` YunQiang Su
2022-10-31 17:22 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b020cd8-98e7-fea0-6cb8-9e33fe955538@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=aurelien@aurel32.net \
--cc=libc-alpha@sourceware.org \
--cc=syq@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).