From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-89039-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 101974 invoked by alias); 10 Jan 2018 20:21:37 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 101956 invoked by uid 89); 10 Jan 2018 20:21:36 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=perfect
X-HELO: mail-qk0-f196.google.com
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:subject:to:references:from:organization
         :message-id:date:user-agent:mime-version:in-reply-to
         :content-language:content-transfer-encoding;
        bh=rs4CZKLwx0c2672rLq/Fy5CRGYV5Y32im6QxD5qKzDU=;
        b=liFnpQA/h9cH76coGtH0UiurEiTr+jz0BAYCyZ+cX4mvhM/PYVdnA6uGWQ3FL5F0yY
         r/As9X2bKx78OGcgTOYHJ6HFCpFu/71tjipaqW/AhFn3Sf8lLRtcWAM5CfsDDLk5ivKm
         wm+xLJS7H+XGClSonJTpXuzl8eiY88yDNQnL0EoDDYB+ZW9Tk+VZkLezPaBFrrJUQMkc
         FsQQFnbMMSE+UPJ5Rq50OUl6lY0M9ecI7cMclJZMH9Y3YHa9Z3ZbBJu+cQPipdC3GDa2
         4CaT30Dyu0vSH6AvTc4VN84ZgI+WQ816JKa8XMAPduQmixAQPXl0ixjlRCVQ+UNHRNO7
         JASg==
X-Gm-Message-State: AKwxytcr6pvGNnWgmbV0TeM9QTpOhL5PzZ0cZsFmilwLeNAw6oyaSL/s
	U4NZ3Ugub063uaqMNtGc2KpXP+MUJME=
X-Google-Smtp-Source: ACJfBouGyzxiID4olE9lx4LSTMe8S7CE9ntUZp+wzcp6OVxdI8ZjNM4OsJfJqCZ0IvuYwOMusv+pEA==
X-Received: by 10.237.52.228 with SMTP id x91mr29430585qtd.42.1515615693652;
        Wed, 10 Jan 2018 12:21:33 -0800 (PST)
Subject: Re: [PATCH] nptl: Open libgcc.so with RTLD_NOW during pthread_cancel
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
References: <20180110104903.A4F88439942E1@oldenburg.str.redhat.com>
 <c5dbae0e-18ec-8f76-061b-3436b55b4de7@redhat.com>
 <f7bab1f7-746f-cda3-928c-caa565802f2e@redhat.com>
 <0e8290f2-4c7f-2d1e-1bdd-09f6d4770947@redhat.com>
 <27824c97-0aa6-4dd3-9efb-832a678b2ebd@redhat.com>
From: Carlos O'Donell <carlos@redhat.com>
Message-ID: <2b24567b-6c8f-452b-3c8f-280a1e9fc7bf@redhat.com>
Date: Wed, 10 Jan 2018 20:21:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <27824c97-0aa6-4dd3-9efb-832a678b2ebd@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2018-01/txt/msg00343.txt.bz2

On 01/10/2018 12:03 PM, Florian Weimer wrote:
> On 01/10/2018 08:29 PM, Carlos O'Donell wrote:
> 
>> What I want to avoid is two similar pieces of code that do distinct
>> things. Is there any reason we shouldn't just checkin a change here
>> that makes both the same, thus avoiding differences?
> 
> Okay, then let's add a comment.

Perfect. LGTM.

Reviewed-by: Carlos O'Donell <carlos@redhat.com>

-- 
Cheers,
Carlos.