public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Siddhesh Poyarekar <siddhesh@sourceware.org>, libc-alpha@sourceware.org
Cc: fweimer@redhat.com
Subject: Re: [PATCH] Enable _FORTIFY_SOURCE=3 for gcc 12 and above
Date: Fri, 17 Dec 2021 16:48:44 -0300	[thread overview]
Message-ID: <2b5a6328-6058-f75d-859d-74781f199376@linaro.org> (raw)
In-Reply-To: <9e05190c-1778-4fba-640b-8dac9cc9f758@sourceware.org>



On 17/12/2021 16:30, Siddhesh Poyarekar wrote:
> On 12/18/21 00:34, Adhemerval Zanella wrote:
>> I am not sure I am following what is happening here, is the test wrong for
>> _FORTIFY_SOURCE=3, our _FORTIFY_SOURCE=3 lacking some hardening, or missing
>> upstream gcc support?
> 
> It's missing some support upstream.  Basically the series is this:
> 
> https://patchwork.sourceware.org/project/gcc/list/?series=5387&state=*
> 
> where I've committed 1/6 and 2/6, thus adding __builtin_dynamic_object_size identification to gcc.  However, the actual dynamic expression generation is in patches 3-6, which is why the tests are failing.
> 
> I may not be able to finish updating and pushing all the patches before glibc freeze.

Right, it this case I am afraid we will need to hold enabling _FORTIFY_SOURCE=3 
until we get proper and complete support from compiler.

  reply	other threads:[~2021-12-17 19:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17  4:07 Siddhesh Poyarekar
2021-12-17 13:17 ` Adhemerval Zanella
2021-12-17 13:54   ` Siddhesh Poyarekar
2021-12-17 15:24     ` Siddhesh Poyarekar
2021-12-17 19:04       ` Adhemerval Zanella
2021-12-17 19:30         ` Siddhesh Poyarekar
2021-12-17 19:48           ` Adhemerval Zanella [this message]
2021-12-17 19:50             ` Siddhesh Poyarekar
2022-01-12  4:14   ` Siddhesh Poyarekar
2022-01-12 12:52     ` Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b5a6328-6058-f75d-859d-74781f199376@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    --cc=siddhesh@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).