From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id 548D13858407 for ; Fri, 17 Dec 2021 19:48:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 548D13858407 Received: by mail-qk1-x731.google.com with SMTP id de30so3302068qkb.0 for ; Fri, 17 Dec 2021 11:48:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gfUgNchTPQM8QrZQVu/UexQv+s7daliicxnpvtj2xQU=; b=ft3g9YP3PV0blUx/p0yyipYMu1efFqMv4sAetIECXsADCF9qh4mnGAXFi8D25d506H zEM26YHLcvk8rG6SJ6yn2TKLy/Od/FWzRddjtCiKvIfvba2rS6ZxTyltplT51dY5RfDq k5Et1NO71hSMc3YuvqB2AM5jKCy95BTafr353J6HbTerRtga4Tw+GSc9F60Gl8hESxFh n4CMJUd+IxjZhwp3W+cVPIIgV5RT9As3CageDr97ftF5T8Hwc3jQhuXEvYbxMVDio8xF R1uh9vAaRaksTkSgwCz5BT3st11g71Q8uSKW6SCjy3fFZEPQVQcl0wdsD41yXih12LNe sEpg== X-Gm-Message-State: AOAM531tRQljGBInvsrTFcEv8wgqY5g36rlvSBfBV3Vs7Zluwvc5M53I a75LTRWJiCuTGItpWbOTOZHXtQ== X-Google-Smtp-Source: ABdhPJzbrBZP7v5m468OR6GBDea5B//myI5rABAglI47GAxmiDw/GLoDA7nedopl/FDvbKrfBX3HlQ== X-Received: by 2002:ae9:f701:: with SMTP id s1mr2886947qkg.425.1639770526903; Fri, 17 Dec 2021 11:48:46 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:7084:332e:7513:f115? ([2804:431:c7ca:103f:7084:332e:7513:f115]) by smtp.gmail.com with ESMTPSA id v16sm5333775qkj.93.2021.12.17.11.48.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 11:48:46 -0800 (PST) Message-ID: <2b5a6328-6058-f75d-859d-74781f199376@linaro.org> Date: Fri, 17 Dec 2021 16:48:44 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH] Enable _FORTIFY_SOURCE=3 for gcc 12 and above Content-Language: en-US To: Siddhesh Poyarekar , libc-alpha@sourceware.org Cc: fweimer@redhat.com References: <20211217040753.4176265-1-siddhesh@sourceware.org> <3056eec8-7cb4-eab7-0726-ecdefc4e4121@sourceware.org> <369f5904-4be8-90e8-0174-1a5f874e48b8@linaro.org> <9e05190c-1778-4fba-640b-8dac9cc9f758@sourceware.org> From: Adhemerval Zanella In-Reply-To: <9e05190c-1778-4fba-640b-8dac9cc9f758@sourceware.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 19:48:48 -0000 On 17/12/2021 16:30, Siddhesh Poyarekar wrote: > On 12/18/21 00:34, Adhemerval Zanella wrote: >> I am not sure I am following what is happening here, is the test wrong for >> _FORTIFY_SOURCE=3, our _FORTIFY_SOURCE=3 lacking some hardening, or missing >> upstream gcc support? > > It's missing some support upstream.  Basically the series is this: > > https://patchwork.sourceware.org/project/gcc/list/?series=5387&state=* > > where I've committed 1/6 and 2/6, thus adding __builtin_dynamic_object_size identification to gcc.  However, the actual dynamic expression generation is in patches 3-6, which is why the tests are failing. > > I may not be able to finish updating and pushing all the patches before glibc freeze. Right, it this case I am afraid we will need to hold enabling _FORTIFY_SOURCE=3 until we get proper and complete support from compiler.