public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: "Frédéric Bérat" <fberat@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH v3 04/16] string: Ensure *_chk routines have their hidden builtin definition available
Date: Fri, 30 Jun 2023 11:06:47 -0400	[thread overview]
Message-ID: <2b5d7821-0dc0-d10d-3efe-f1bbc904fd15@gotplt.org> (raw)
In-Reply-To: <20230628084246.778302-5-fberat@redhat.com>



On 2023-06-28 04:42, Frédéric Bérat wrote:
> If libc_hidden_builtin_{def,proto} isn't properly set for *_chk routines,
> there are unwanted PLT entries in libc.so.
> ---

LGTM.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>

>   debug/memcpy_chk.c                        | 1 +
>   debug/memmove_chk.c                       | 1 +
>   debug/mempcpy_chk.c                       | 1 +
>   debug/memset_chk.c                        | 1 +
>   debug/stpcpy_chk.c                        | 1 +
>   include/string.h                          | 7 +++++++
>   sysdeps/i386/i586/memcpy.S                | 1 +
>   sysdeps/i386/i586/memset.S                | 1 +
>   sysdeps/i386/i686/memcpy.S                | 1 +
>   sysdeps/i386/i686/memmove.S               | 1 +
>   sysdeps/i386/i686/mempcpy.S               | 1 +
>   sysdeps/i386/i686/memset.S                | 1 +
>   sysdeps/i386/i686/multiarch/memcpy_chk.c  | 4 ++++
>   sysdeps/i386/i686/multiarch/memmove_chk.c | 4 ++++
>   sysdeps/i386/i686/multiarch/mempcpy_chk.c | 4 ++++
>   sysdeps/i386/i686/multiarch/memset_chk.c  | 5 ++++-
>   sysdeps/i386/memcpy_chk.S                 | 1 +
>   sysdeps/i386/memmove_chk.S                | 1 +
>   sysdeps/i386/mempcpy_chk.S                | 1 +
>   sysdeps/i386/memset_chk.S                 | 1 +
>   sysdeps/x86_64/memcpy_chk.S               | 1 +
>   sysdeps/x86_64/memmove_chk.S              | 1 +
>   sysdeps/x86_64/mempcpy_chk.S              | 1 +
>   sysdeps/x86_64/memset_chk.S               | 1 +
>   sysdeps/x86_64/multiarch/memcpy_chk.c     | 4 ++++
>   sysdeps/x86_64/multiarch/memmove_chk.c    | 4 ++++
>   sysdeps/x86_64/multiarch/mempcpy_chk.c    | 4 ++++
>   sysdeps/x86_64/multiarch/memset_chk.c     | 4 ++++
>   28 files changed, 58 insertions(+), 1 deletion(-)
> 
> diff --git a/debug/memcpy_chk.c b/debug/memcpy_chk.c
> index c6dd94c83f..1e4a82c063 100644
> --- a/debug/memcpy_chk.c
> +++ b/debug/memcpy_chk.c
> @@ -28,3 +28,4 @@ __memcpy_chk (void *dstpp, const void *srcpp, size_t len, size_t dstlen)
>   
>     return memcpy (dstpp, srcpp, len);
>   }
> +libc_hidden_builtin_def (__memcpy_chk)
> diff --git a/debug/memmove_chk.c b/debug/memmove_chk.c
> index 8922a1ba26..b714aa474c 100644
> --- a/debug/memmove_chk.c
> +++ b/debug/memmove_chk.c
> @@ -32,3 +32,4 @@ MEMMOVE_CHK (void *dest, const void *src, size_t len, size_t destlen)
>   
>     return memmove (dest, src, len);
>   }
> +libc_hidden_builtin_def (MEMMOVE_CHK)
> diff --git a/debug/mempcpy_chk.c b/debug/mempcpy_chk.c
> index 17a46a3b4d..b47b14ee9a 100644
> --- a/debug/mempcpy_chk.c
> +++ b/debug/mempcpy_chk.c
> @@ -29,3 +29,4 @@ __mempcpy_chk (void *dstpp, const void *srcpp, size_t len, size_t dstlen)
>   
>     return __mempcpy (dstpp, srcpp, len);
>   }
> +libc_hidden_builtin_def (__mempcpy_chk)
> diff --git a/debug/memset_chk.c b/debug/memset_chk.c
> index 4fc0b55d82..93901f5f34 100644
> --- a/debug/memset_chk.c
> +++ b/debug/memset_chk.c
> @@ -26,3 +26,4 @@ __memset_chk (void *dstpp, int c, size_t len, size_t dstlen)
>   
>     return memset (dstpp, c, len);
>   }
> +libc_hidden_builtin_def (__memset_chk)
> diff --git a/debug/stpcpy_chk.c b/debug/stpcpy_chk.c
> index 230b52bd01..518dd78dca 100644
> --- a/debug/stpcpy_chk.c
> +++ b/debug/stpcpy_chk.c
> @@ -32,3 +32,4 @@ __stpcpy_chk (char *dest, const char *src, size_t destlen)
>   
>     return memcpy (dest, src, len + 1) + len;
>   }
> +libc_hidden_builtin_def (__stpcpy_chk)
> diff --git a/include/string.h b/include/string.h
> index 0c78ad2539..659530d1aa 100644
> --- a/include/string.h
> +++ b/include/string.h
> @@ -208,6 +208,13 @@ extern char *__strcat_chk (char *__restrict __dest,
>   extern char *__strncat_chk (char *__restrict __dest,
>   			    const char *__restrict __src,
>   			    size_t __len, size_t __destlen) __THROW;
> +
> +libc_hidden_builtin_proto (__memcpy_chk)
> +libc_hidden_builtin_proto (__memmove_chk)
> +libc_hidden_builtin_proto (__mempcpy_chk)
> +libc_hidden_builtin_proto (__memset_chk)
> +libc_hidden_builtin_proto (__stpcpy_chk)
> +
>   #endif
>   
>   #endif
> diff --git a/sysdeps/i386/i586/memcpy.S b/sysdeps/i386/i586/memcpy.S
> index 58061d5adf..e3405e577c 100644
> --- a/sysdeps/i386/i586/memcpy.S
> +++ b/sysdeps/i386/i586/memcpy.S
> @@ -32,6 +32,7 @@ ENTRY (__memcpy_chk)
>   	cmpl	%eax, 16(%esp)
>   	jb	HIDDEN_JUMPTARGET (__chk_fail)
>   END (__memcpy_chk)
> +libc_hidden_builtin_def (__memcpy_chk)
>   #endif
>   ENTRY (memcpy)
>   
> diff --git a/sysdeps/i386/i586/memset.S b/sysdeps/i386/i586/memset.S
> index 413e8ec6a9..f1f0e1a99b 100644
> --- a/sysdeps/i386/i586/memset.S
> +++ b/sysdeps/i386/i586/memset.S
> @@ -33,6 +33,7 @@ ENTRY (__memset_chk)
>   	cmpl	%eax, 16(%esp)
>   	jb	HIDDEN_JUMPTARGET (__chk_fail)
>   END (__memset_chk)
> +libc_hidden_builtin_def (__memset_chk)
>   #endif
>   ENTRY (memset)
>   
> diff --git a/sysdeps/i386/i686/memcpy.S b/sysdeps/i386/i686/memcpy.S
> index 604d3088f6..9b48ec0ea1 100644
> --- a/sysdeps/i386/i686/memcpy.S
> +++ b/sysdeps/i386/i686/memcpy.S
> @@ -33,6 +33,7 @@ ENTRY_CHK (__memcpy_chk)
>   	cmpl	%eax, 16(%esp)
>   	jb	HIDDEN_JUMPTARGET (__chk_fail)
>   END_CHK (__memcpy_chk)
> +libc_hidden_builtin_def (__memcpy_chk)
>   #endif
>   ENTRY (memcpy)
>   
> diff --git a/sysdeps/i386/i686/memmove.S b/sysdeps/i386/i686/memmove.S
> index cff06c27e5..06fe2a7668 100644
> --- a/sysdeps/i386/i686/memmove.S
> +++ b/sysdeps/i386/i686/memmove.S
> @@ -35,6 +35,7 @@ ENTRY_CHK (__memmove_chk)
>   	cmpl	%eax, 16(%esp)
>   	jb	HIDDEN_JUMPTARGET (__chk_fail)
>   END_CHK (__memmove_chk)
> +libc_hidden_builtin_def (__memmove_chk)
>   #endif
>   
>   ENTRY (memmove)
> diff --git a/sysdeps/i386/i686/mempcpy.S b/sysdeps/i386/i686/mempcpy.S
> index af3f2cca08..26f8501e7d 100644
> --- a/sysdeps/i386/i686/mempcpy.S
> +++ b/sysdeps/i386/i686/mempcpy.S
> @@ -33,6 +33,7 @@ ENTRY_CHK (__mempcpy_chk)
>   	cmpl	%eax, 16(%esp)
>   	jb	HIDDEN_JUMPTARGET (__chk_fail)
>   END_CHK (__mempcpy_chk)
> +libc_hidden_builtin_def (__mempcpy_chk)
>   #endif
>   ENTRY (__mempcpy)
>   
> diff --git a/sysdeps/i386/i686/memset.S b/sysdeps/i386/i686/memset.S
> index d4891880d7..0b5e671d83 100644
> --- a/sysdeps/i386/i686/memset.S
> +++ b/sysdeps/i386/i686/memset.S
> @@ -33,6 +33,7 @@ ENTRY_CHK (__memset_chk)
>   	cmpl	%eax, 16(%esp)
>   	jb	HIDDEN_JUMPTARGET (__chk_fail)
>   END_CHK (__memset_chk)
> +libc_hidden_builtin_def (__memset_chk)
>   #endif
>   ENTRY (memset)
>   
> diff --git a/sysdeps/i386/i686/multiarch/memcpy_chk.c b/sysdeps/i386/i686/multiarch/memcpy_chk.c
> index 5ac5cb1d7a..ec945dc91f 100644
> --- a/sysdeps/i386/i686/multiarch/memcpy_chk.c
> +++ b/sysdeps/i386/i686/multiarch/memcpy_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_memcpy_chk, __memcpy_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__memcpy_chk, __GI___memcpy_chk, __redirect_memcpy_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__memcpy_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/i386/i686/multiarch/memmove_chk.c b/sysdeps/i386/i686/multiarch/memmove_chk.c
> index 28161d3c27..55c7601d5d 100644
> --- a/sysdeps/i386/i686/multiarch/memmove_chk.c
> +++ b/sysdeps/i386/i686/multiarch/memmove_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_memmove_chk, __memmove_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__memmove_chk, __GI___memmove_chk, __redirect_memmove_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__memmove_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/i386/i686/multiarch/mempcpy_chk.c b/sysdeps/i386/i686/multiarch/mempcpy_chk.c
> index 36c81ae61a..83569cf9d9 100644
> --- a/sysdeps/i386/i686/multiarch/mempcpy_chk.c
> +++ b/sysdeps/i386/i686/multiarch/mempcpy_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_mempcpy_chk, __mempcpy_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__mempcpy_chk, __GI___mempcpy_chk, __redirect_mempcpy_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__mempcpy_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/i386/i686/multiarch/memset_chk.c b/sysdeps/i386/i686/multiarch/memset_chk.c
> index cf3e811327..1a7503858d 100644
> --- a/sysdeps/i386/i686/multiarch/memset_chk.c
> +++ b/sysdeps/i386/i686/multiarch/memset_chk.c
> @@ -28,5 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_memset_chk, __memset_chk,
>   		       IFUNC_SELECTOR ());
> -
> +# ifdef SHARED
> +__hidden_ver1 (__memset_chk, __GI___memset_chk, __redirect_memset_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__memset_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/i386/memcpy_chk.S b/sysdeps/i386/memcpy_chk.S
> index b5244cc69b..7b12c12aba 100644
> --- a/sysdeps/i386/memcpy_chk.S
> +++ b/sysdeps/i386/memcpy_chk.S
> @@ -31,4 +31,5 @@ ENTRY (__memcpy_chk)
>   	jb	__chk_fail
>   	jmp	memcpy
>   END (__memcpy_chk)
> +libc_hidden_builtin_def (__memcpy_chk)
>   #endif
> diff --git a/sysdeps/i386/memmove_chk.S b/sysdeps/i386/memmove_chk.S
> index 517d8cb15a..604aea8305 100644
> --- a/sysdeps/i386/memmove_chk.S
> +++ b/sysdeps/i386/memmove_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__memmove_chk)
>   	jb	__chk_fail
>   	jmp	memmove
>   END (__memmove_chk)
> +libc_hidden_builtin_def (MEMMOVE_CHK)
>   #endif
> diff --git a/sysdeps/i386/mempcpy_chk.S b/sysdeps/i386/mempcpy_chk.S
> index 1e9bf71bfb..276eab1e8a 100644
> --- a/sysdeps/i386/mempcpy_chk.S
> +++ b/sysdeps/i386/mempcpy_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__mempcpy_chk)
>   	jb	__chk_fail
>   	jmp	__mempcpy
>   END (__mempcpy_chk)
> +libc_hidden_builtin_def (__mempcpy_chk)
>   #endif
> diff --git a/sysdeps/i386/memset_chk.S b/sysdeps/i386/memset_chk.S
> index 0e6060a0a6..a2e9208e1c 100644
> --- a/sysdeps/i386/memset_chk.S
> +++ b/sysdeps/i386/memset_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__memset_chk)
>   	jb	__chk_fail
>   	jmp	memset
>   END (__memset_chk)
> +libc_hidden_builtin_def (__memset_chk)
>   #endif
> diff --git a/sysdeps/x86_64/memcpy_chk.S b/sysdeps/x86_64/memcpy_chk.S
> index 25cbeb37ee..43843a7abb 100644
> --- a/sysdeps/x86_64/memcpy_chk.S
> +++ b/sysdeps/x86_64/memcpy_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__memcpy_chk)
>   	jb	__chk_fail
>   	jmp	memcpy
>   END (__memcpy_chk)
> +libc_hidden_builtin_def (__memcpy_chk)
>   #endif
> diff --git a/sysdeps/x86_64/memmove_chk.S b/sysdeps/x86_64/memmove_chk.S
> index 165d42cfa8..37e2c30ba8 100644
> --- a/sysdeps/x86_64/memmove_chk.S
> +++ b/sysdeps/x86_64/memmove_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__memmove_chk)
>   	jb	__chk_fail
>   	jmp	memmove
>   END (__memmove_chk)
> +libc_hidden_builtin_def (MEMMOVE_CHK)
>   #endif
> diff --git a/sysdeps/x86_64/mempcpy_chk.S b/sysdeps/x86_64/mempcpy_chk.S
> index b60ee4ff08..facdac50d8 100644
> --- a/sysdeps/x86_64/mempcpy_chk.S
> +++ b/sysdeps/x86_64/mempcpy_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__mempcpy_chk)
>   	jb	__chk_fail
>   	jmp	__mempcpy
>   END (__mempcpy_chk)
> +libc_hidden_builtin_def (__mempcpy_chk)
>   #endif
> diff --git a/sysdeps/x86_64/memset_chk.S b/sysdeps/x86_64/memset_chk.S
> index ed53b8927f..c927884b1a 100644
> --- a/sysdeps/x86_64/memset_chk.S
> +++ b/sysdeps/x86_64/memset_chk.S
> @@ -30,4 +30,5 @@ ENTRY (__memset_chk)
>   	jb	__chk_fail
>   	jmp	memset
>   END (__memset_chk)
> +libc_hidden_builtin_def (__memset_chk)
>   #endif
> diff --git a/sysdeps/x86_64/multiarch/memcpy_chk.c b/sysdeps/x86_64/multiarch/memcpy_chk.c
> index 5ac5cb1d7a..ec945dc91f 100644
> --- a/sysdeps/x86_64/multiarch/memcpy_chk.c
> +++ b/sysdeps/x86_64/multiarch/memcpy_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_memcpy_chk, __memcpy_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__memcpy_chk, __GI___memcpy_chk, __redirect_memcpy_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__memcpy_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/x86_64/multiarch/memmove_chk.c b/sysdeps/x86_64/multiarch/memmove_chk.c
> index 28161d3c27..55c7601d5d 100644
> --- a/sysdeps/x86_64/multiarch/memmove_chk.c
> +++ b/sysdeps/x86_64/multiarch/memmove_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_memmove_chk, __memmove_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__memmove_chk, __GI___memmove_chk, __redirect_memmove_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__memmove_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/x86_64/multiarch/mempcpy_chk.c b/sysdeps/x86_64/multiarch/mempcpy_chk.c
> index 36c81ae61a..83569cf9d9 100644
> --- a/sysdeps/x86_64/multiarch/mempcpy_chk.c
> +++ b/sysdeps/x86_64/multiarch/mempcpy_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_mempcpy_chk, __mempcpy_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__mempcpy_chk, __GI___mempcpy_chk, __redirect_mempcpy_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__mempcpy_chk);
> +# endif
>   #endif
> diff --git a/sysdeps/x86_64/multiarch/memset_chk.c b/sysdeps/x86_64/multiarch/memset_chk.c
> index d81147a70c..1a7503858d 100644
> --- a/sysdeps/x86_64/multiarch/memset_chk.c
> +++ b/sysdeps/x86_64/multiarch/memset_chk.c
> @@ -28,4 +28,8 @@
>   
>   libc_ifunc_redirected (__redirect_memset_chk, __memset_chk,
>   		       IFUNC_SELECTOR ());
> +# ifdef SHARED
> +__hidden_ver1 (__memset_chk, __GI___memset_chk, __redirect_memset_chk)
> +  __attribute__ ((visibility ("hidden"))) __attribute_copy__ (__memset_chk);
> +# endif
>   #endif

  reply	other threads:[~2023-06-30 15:06 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-28  8:42 [PATCH v3 00/16] Allow glibc to be built with _FORTIFY_SOURCE Frédéric Bérat
2023-06-28  8:42 ` [PATCH v3 01/16] " Frédéric Bérat
2023-06-28 14:48   ` Joseph Myers
2023-06-28  8:42 ` [PATCH v3 02/16] Exclude routines from fortification Frédéric Bérat
2023-06-30 14:55   ` Siddhesh Poyarekar
2023-07-03 15:16     ` Frederic Berat
2023-07-04 16:04       ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 03/16] sysdeps: Ensure ieee128*_chk routines to be properly named Frédéric Bérat
2023-06-30 14:58   ` Siddhesh Poyarekar
2023-06-30 15:55     ` Paul E Murphy
2023-06-30 15:57       ` Frederic Berat
2023-06-28  8:42 ` [PATCH v3 04/16] string: Ensure *_chk routines have their hidden builtin definition available Frédéric Bérat
2023-06-30 15:06   ` Siddhesh Poyarekar [this message]
2023-06-28  8:42 ` [PATCH v3 05/16] stdio: " Frédéric Bérat
2023-06-30 15:09   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 06/16] asprintf_chk: Ensure compatibility for both s390x and ppc64le Frédéric Bérat
2023-06-30 15:11   ` Siddhesh Poyarekar
2023-06-30 16:08     ` Rajalakshmi Srinivasaraghavan
2023-06-30 17:51   ` Paul E Murphy
2023-07-03  5:35     ` Frederic Berat
2023-06-28  8:42 ` [PATCH v3 07/16] misc/sys/cdefs.h: Create FORTIFY redirects for internal calls Frédéric Bérat
2023-06-30 15:13   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 08/16] wchar: Avoid PLT entries with _FORTIFY_SOURCE Frédéric Bérat
2023-06-30 15:17   ` Siddhesh Poyarekar
2023-06-30 15:26     ` Frederic Berat
2023-06-28  8:42 ` [PATCH v3 09/16] posix/bits/unistd.h: Clearly separate declaration from definitions Frédéric Bérat
2023-06-30 15:19   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 10/16] unistd: Avoid PLT entries with _FORTIFY_SOURCE Frédéric Bérat
2023-06-30 15:25   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 11/16] misc/bits/select2.h: Clearly separate declaration from definitions Frédéric Bérat
2023-06-30 15:26   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 12/16] misc/bits/syslog.h: Clearly separate declaration from definition Frédéric Bérat
2023-06-30 15:28   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 13/16] libio/bits/stdio2.h: Clearly separate declaration from definitions Frédéric Bérat
2023-06-30 15:29   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 14/16] libio/bits/stdio2-decl.h: Avoid PLT entries with _FORTIFY_SOURCE Frédéric Bérat
2023-06-30 15:30   ` Siddhesh Poyarekar
2023-06-30 15:38     ` Frederic Berat
2023-06-30 15:48       ` Siddhesh Poyarekar
2023-06-30 17:08         ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 15/16] sysdeps/ieee754/ldbl-128ibm-compat: Fix warn unused result Frédéric Bérat
2023-06-30 15:33   ` Siddhesh Poyarekar
2023-06-28  8:42 ` [PATCH v3 16/16] Add --enable-fortify-source option Frédéric Bérat
2023-06-30 13:51   ` Siddhesh Poyarekar
2023-07-03  8:50     ` Andreas Schwab
2023-07-03 12:51       ` Adhemerval Zanella Netto
2023-07-04 12:40         ` Frederic Berat
2023-07-04 15:59           ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2b5d7821-0dc0-d10d-3efe-f1bbc904fd15@gotplt.org \
    --to=siddhesh@gotplt.org \
    --cc=fberat@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).