From: Carlos O'Donell <carlos@redhat.com>
To: Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
'GNU C Library' <libc-alpha@sourceware.org>,
DJ Delorie <dj@redhat.com>
Subject: Re: [PATCH v4] Remove catomics
Date: Mon, 17 Oct 2022 17:56:21 -0400 [thread overview]
Message-ID: <2b91ee78-9c46-edbd-96ee-cc078475b331@redhat.com> (raw)
In-Reply-To: <AS4PR08MB7901C65B533B5A75D3949BFC83299@AS4PR08MB7901.eurprd08.prod.outlook.com>
On 10/17/22 10:50, Wilco Dijkstra wrote:
> Hi Carlos,
>
>> Fails pre-commit CI:
>> https://patchwork.sourceware.org/project/glibc/patch/AS4PR08MB7901F6228D9EF556A3FE027D83249@AS4PR08MB7901.eurprd08.prod.outlook.com/
>>
>> Could you please review?
>
> It works fine for me - the patch merges using patch -p 1 -i <patchfile>.
> What settings do you use in the CI?
git apply -p1
https://gitlab.com/djdelorie/glibc-cicd/-/blob/main/trybot-apply_patch.py#L65
--
Cheers,
Carlos.
next prev parent reply other threads:[~2022-10-17 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-14 16:38 Wilco Dijkstra
2022-10-17 13:25 ` Carlos O'Donell
2022-10-17 14:50 ` Wilco Dijkstra
2022-10-17 21:56 ` Carlos O'Donell [this message]
2022-10-18 13:01 ` Wilco Dijkstra
2022-10-18 13:34 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b91ee78-9c46-edbd-96ee-cc078475b331@redhat.com \
--to=carlos@redhat.com \
--cc=Wilco.Dijkstra@arm.com \
--cc=dj@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).