From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>,
Adhemerval Zanella via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH v3 1/4] support: Add xclone
Date: Tue, 9 Mar 2021 13:17:29 -0300 [thread overview]
Message-ID: <2bd31e3a-5681-0ba0-adf7-08f45c8beaf6@linaro.org> (raw)
In-Reply-To: <87y2ew65ww.fsf@oldenburg.str.redhat.com>
On 09/03/2021 06:19, Florian Weimer wrote:
> * Adhemerval Zanella via Libc-alpha:
>
>> +#ifdef __linux__
>> +# define DEFINE_STACK(name, size) \
>> + char name[size] __attribute__ ((aligned))
>
> In the light of the MINSIGSTKSZ problems, is this really an appropriate
> interface? Should there be separate functions for stack allocation and
> deallocation?
Indeed, I think routines similar to xalloc_sigstack should be better
than this ad hoc routine to make the stack correctly aligned.
>
> The actual xclone implementation looks okay to me.
>
> Thanks,
> Florian
>
prev parent reply other threads:[~2021-03-09 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 16:36 Adhemerval Zanella
2020-12-23 16:36 ` [PATCH v3 2/4] Linux: Add close_range Adhemerval Zanella
2021-03-09 9:47 ` Florian Weimer
2021-03-09 10:02 ` Christian Brauner
2021-03-09 17:53 ` Adhemerval Zanella
2021-03-09 18:30 ` Florian Weimer
2020-12-23 16:36 ` [PATCH v3 3/4] io: Add closefrom [BZ #10353] Adhemerval Zanella
2021-03-09 10:23 ` Florian Weimer
2021-03-09 19:07 ` Adhemerval Zanella
2020-12-23 16:36 ` [PATCH v3 4/4] posix: Add posix_spawn_file_actions_closefrom Adhemerval Zanella
2021-03-09 10:45 ` Florian Weimer
2021-03-09 19:48 ` Adhemerval Zanella
2021-03-09 20:00 ` Florian Weimer
2021-03-09 20:04 ` Adhemerval Zanella
2021-03-09 9:19 ` [PATCH v3 1/4] support: Add xclone Florian Weimer
2021-03-09 16:17 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd31e3a-5681-0ba0-adf7-08f45c8beaf6@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).