From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x30.google.com (mail-oa1-x30.google.com [IPv6:2001:4860:4864:20::30]) by sourceware.org (Postfix) with ESMTPS id CFF6F3858D35 for ; Wed, 15 Feb 2023 14:25:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CFF6F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x30.google.com with SMTP id 586e51a60fabf-16e2c22c3baso6550851fac.8 for ; Wed, 15 Feb 2023 06:25:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=ZZRH1uQIR/8IHjzaI8ZW/sn+DbWylz2mG47GjweukaQ=; b=CzKpLRVFMCjOuW075xr1CP7bize/8oi/ta2eprdtf4DrMXtVFh0XbiNlejrtWraZlA MyEdi5Bv5wSWiHlCEOTS6uDd+I60FyLdQhW/v7CQ+SNAteUeSq+HSUawVW8hcJfdSA4/ PIFqMm7cnrUyKAJ9IHkyp0pSctgoxPvX5s/6B7x2MayoRH5pJgyAyGmS84+9qkNTqCh4 7V2mseHVSuUR11PuVe6BlT6CrjJfI32EOp6xSqQmEXbMHJkS3AalWwwDfr6PMfiUmtxa UhTTjMjlMvsvItsZYVRjgdXDzp6n7pNNpH1KT4i7vfQU8B6aNbOPB/PBzWJPJmAbTSOQ p+Lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZZRH1uQIR/8IHjzaI8ZW/sn+DbWylz2mG47GjweukaQ=; b=iAQYwX2dcx6M1bcNkw4WByS7B/Zj1LQ2tQLYokyMvF7XeKHgoLl046Ur/Ii6GJUCK8 b4Lh4pmP4EVvguo9tGuHnGGlv6F/vhDx4Gx154Sjcgf9m4KGqrsR+gpIX084i2z8YSJZ XMiL0HOljPMPO3h3G29+UvtUT87Mrn7aNqN91RhAgSiEMRsSJ1YVgzRwjd43LLTPyKH9 uP/gBxnUy0ot01XMpvT8FnhJGrayh5rRi3lHus4Pp7Fy6qtMsHI66F/rRsVkwaa5/v0m dbaXSSTcJGeGd1bTmc9+EO1MZ/44S7UlD132Caf1bL/4yUb58QHDqevZUCRd3MxVwJhO eIoQ== X-Gm-Message-State: AO0yUKXRyZ+8vm/yu9R1GeyGmn/ztwTp16UWOQ1i88z1JAE8aV3LwwSk qfW0GUbRMSjRFV1pl5XibcAcew== X-Google-Smtp-Source: AK7set9+dY261ywKKW8Cx/Fol7bv/9xRUlDv8TeVEUygzWyD3sAT8ORaclJKcLgVGymJTmOEOPt55Q== X-Received: by 2002:a05:6870:20c:b0:16d:ec6a:71f4 with SMTP id j12-20020a056870020c00b0016dec6a71f4mr1161303oad.30.1676471138754; Wed, 15 Feb 2023 06:25:38 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c3:3a5:44ad:5aad:f16a:f333? ([2804:1b3:a7c3:3a5:44ad:5aad:f16a:f333]) by smtp.gmail.com with ESMTPSA id t5-20020a4adbc5000000b00511e01623bbsm7104690oou.7.2023.02.15.06.25.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Feb 2023 06:25:37 -0800 (PST) Message-ID: <2bd6fce7-d77c-e034-934f-31f85afb9549@linaro.org> Date: Wed, 15 Feb 2023 11:25:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] LoongArch: Add math-barriers.h Content-Language: en-US To: Xi Ruoyao , libc-alpha@sourceware.org Cc: caiyinyu , Wang Xuerui References: <20230214085713.44338-1-xry111@xry111.site> <617e860d-9bf3-ddc0-8791-655e611ad7ac@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 15/02/23 11:22, Xi Ruoyao wrote: > On Wed, 2023-02-15 at 10:47 -0300, Adhemerval Zanella Netto wrote: >> On 14/02/23 05:57, Xi Ruoyao via Libc-alpha wrote: >>> This patch implements the LoongArch specific math barriers in order to omit >>> the store and load from stack if possible. >> >> LGTM, I have not see any regression with qemu.  As a side note, math/test-fenv >> shows a failure so you might take a look, you might need to update ULPs as well. > > Hmm, on a real hardware I saw no failures even with GCC 13 trunk (some > aggressive FVRP optimization has been added into GCC 13). But maybe > things have been changed since my last test. I'll test again. I meant that I saw math/test-fenv failures with and without the patch and I the master qemu (f670b3eec7f5d1ed8c4573ef244e7b8c6b32001b). > >> Reviewed-by: Adhemerval Zanella  >