Hi Maciej, >> @@ -1703,6 +1713,35 @@ typedef struct >> #define EF_MIPS_ARCH_64 0x60000000 /* MIPS64 code. */ >> #define EF_MIPS_ARCH_32R2 0x70000000 /* MIPS32r2 code. */ >> #define EF_MIPS_ARCH_64R2 0x80000000 /* MIPS64r2 code. */ >> +#define E_MIPS_ARCH_32R6 0x90000000 /* -mips32r6 code. */ >> +#define E_MIPS_ARCH_64R6 0xa0000000 /* -mips64r6 code. */ > I think all new additions are supposed to start with EF_ rather than E_. > IIUC the existence of E_ macros has something to do with the old SVR4 ABI > registry maintained by SCO long ago: you could only add new EF_ macros > once they've been registered with SCO (someone please correct me if I'm > wrong). > > Also I think the new comments will best be spelt MIPS32r6/MIPS64r6 rather > than -mips32r6/-mips64r6 for consistency with MIPS32r2/MIPS64r2 above. > Because we did not plan to change binutils E_* to EF_* and hope to sync them to libc, so I would only change related comments. Thanks for all your suggestions. Ying