From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=7DFk=D2=oss.cipunited.com=ying.huang@sourceware.org>
Received: from s01.bc.larksuite.com (s01.bc.larksuite.com [209.127.230.12])
	by sourceware.org (Postfix) with UTF8SMTPS id ED53C3858D20
	for <libc-alpha@sourceware.org>; Wed,  9 Aug 2023 01:46:22 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED53C3858D20
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 s=feishu2303200042; d=oss.cipunited.com; t=1691545578;
  h=from:subject:mime-version:from:date:message-id:subject:to:cc:
 reply-to:content-type:mime-version:in-reply-to:message-id;
 bh=7wzU06C7s0e+rH9FyhyKbjcNn7iHunVIvjr8ggRjL44=;
 b=Oa9G6h9uZSPksbhS1au2JW6tuMaWxYotIdUddl1QLB00+USHdPYr0IWSYgcKIHLQHQ3mm+
 I1UQ/YZWIH0/uX4DaZtFwgB+qdETgwXJxbylK9g7OMRfIHegfBlOVopMfyhFY/RyCpVwmo
 orkSQKvaXGS4V8Zf1ObjIy1N69EeyLxLxpO3Fgm/1M5dfndeGuKwDCZCOShYxZR2wnBMzq
 newmPz09hXKmReeIwhKq8nlZ5nexsXZdvVqhFcMOZLMusSZb5ZkZv0ZI296VxJFemqg17N
 hu8ymnhs4Mr+928cl78lt9rwF2fIOd6v8kAyy7ecMdgo0HSAdtMvYhJqfounUQ==
From: "Ying Huang" <ying.huang@oss.cipunited.com>
Date: Wed, 9 Aug 2023 09:46:15 +0800
Mime-Version: 1.0
Content-Type: multipart/alternative;
 boundary=5e7d189d9a67892c9361426e4f2ac4d02035e32db4fb5349a597be856c88
Cc: <libc-alpha@sourceware.org>, <yunqiang.su@oss.cipunited.com>
References: <20230602080745.241502-1-ying.huang@oss.cipunited.com> <alpine.DEB.2.21.2306040036090.36323@angie.orcam.me.uk>
In-Reply-To: <alpine.DEB.2.21.2306040036090.36323@angie.orcam.me.uk>
Content-Language: en-US
Subject: Re: [PATCH v4] MIPS: Sync elf.h from binutils
Message-Id: <2be0ad4a-e341-2ab0-acee-7090fe9efda1@oss.cipunited.com>
X-Original-From: Ying Huang <ying.huang@oss.cipunited.com>
X-Lms-Return-Path: <lba+264d2efe9+acfa4d+sourceware.org+ying.huang@oss.cipunited.com>
To: "Maciej W. Rozycki" <macro@orcam.me.uk>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_INVALID,DKIM_SIGNED,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <libc-alpha.sourceware.org>

--5e7d189d9a67892c9361426e4f2ac4d02035e32db4fb5349a597be856c88
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8

Hi Maciej,

>> @@ -1703,6 +1713,35 @@ typedef struct
>>  #define EF_MIPS_ARCH_64		0x60000000 /* MIPS64 code.  */
>>  #define EF_MIPS_ARCH_32R2	0x70000000 /* MIPS32r2 code.  */
>>  #define EF_MIPS_ARCH_64R2	0x80000000 /* MIPS64r2 code.  */
>> +#define E_MIPS_ARCH_32R6	0x90000000 /* -mips32r6 code.  */
>> +#define E_MIPS_ARCH_64R6	0xa0000000 /* -mips64r6 code.  */
>  I think all new additions are supposed to start with EF_ rather than E_.=
=20=20
> IIUC the existence of E_ macros has something to do with the old SVR4 ABI=
=20
> registry maintained by SCO long ago: you could only add new EF_ macros=20
> once they've been registered with SCO (someone please correct me if I'm=20
> wrong).
>
>  Also I think the new comments will best be spelt MIPS32r6/MIPS64r6 rathe=
r=20
> than -mips32r6/-mips64r6 for consistency with MIPS32r2/MIPS64r2 above.
>
Because we did not plan to change binutils E_* to EF_* and hope to sync the=
m to libc, so I would only change related comments.

Thanks for all your suggestions.

Ying=

--5e7d189d9a67892c9361426e4f2ac4d02035e32db4fb5349a597be856c88--