From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Xianmiao Qu <cooper.qu@linux.alibaba.com>,
libc-alpha@sourceware.org, han_mao@linux.alibaba.com
Cc: fweimer@redhat.com
Subject: Re: [PATCH v2] C-SKY: Strip hard float abi from hard float feature.
Date: Wed, 1 Feb 2023 09:24:48 -0300 [thread overview]
Message-ID: <2c9e84f7-bc00-4516-3690-a8b87ac1768a@linaro.org> (raw)
In-Reply-To: <Y9R+24zrF4hhX+6L@B-7F1WN6HQ-1426.local>
On 27/01/23 22:48, Xianmiao Qu wrote:
> On Fri, Jan 27, 2023 at 04:24:32PM -0300, Adhemerval Zanella Netto wrote:
>>
>>
>> It is not clear to me why you need to use '-mfloat-abi=softfp' to check
>> for soft-float ABI, since it *won't* be used to actually build glibc
>> (meaning that the compiler build invocation not necessary will use the
>> same ABI as the test is doing).
>>
>
> This is for compatibility with versions prior to GCC 11. The older versions
> of C-SKY GCC don't support -mfloat-abi=softfp, so the '__CSKY_HARD_FLOAT_ABI__'
> is always not defined, and the expression 'defined(__CSKY_HARD_FLOAT__) && !defined(__CSKY_HARD_FLOAT_ABI__)'
> which is correct for newer versions of GCC does not work for older versions.
> And there doesn't seem to be an expression compitable with all versions of GCC,
> so I add the check for the '-mfloat-abi=softfp' option.
Right, so please add a comment that the -mfloat-abi=softfp is to check for
older gcc version on the configure.ac (similar to the current one).
prev parent reply other threads:[~2023-02-01 12:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 2:06 Xianmiao Qu
2023-01-27 19:24 ` Adhemerval Zanella Netto
2023-01-28 1:48 ` Xianmiao Qu
2023-02-01 12:24 ` Adhemerval Zanella Netto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c9e84f7-bc00-4516-3690-a8b87ac1768a@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=cooper.qu@linux.alibaba.com \
--cc=fweimer@redhat.com \
--cc=han_mao@linux.alibaba.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).