From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc34.google.com (mail-oo1-xc34.google.com [IPv6:2607:f8b0:4864:20::c34]) by sourceware.org (Postfix) with ESMTPS id 39EDC3858D37 for ; Wed, 1 Feb 2023 12:24:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 39EDC3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-xc34.google.com with SMTP id k15-20020a4adfaf000000b00517450f9bd7so1158002ook.8 for ; Wed, 01 Feb 2023 04:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=wX4op3BZu/NdS4rR8C4CWFo0uWODHG3FdASEyfNSRPQ=; b=LB/EIjoPBk5nBZRUwPyjGosynKXZUosE0dJ6b3CJ8r4ipqdbWl4lljJYyri6vDVYzi y7rcNBxGlI/FzEBoQ5sDPzlwegPqMHsJx5gbW0YpVSckaYE3kamvUoP+GQMRPdKtVLhN +Io57URHhlazVcYsYvg2OnDVPcEJb8QzB+zD06HPUZTNkez9fwCk3qcw6E9JaMxpaV04 ZlTmnwCXDoQWudMtlmQeS6p2A1PAiIzLf8VAjSe8ADk/g7rSRPDEqskD4aeZTNyEk/im uG17pRpBqOKGOKgZv6fSJrINldMmIiO5s81pW2KtMZaNV5fsBurMA2bwT+yaiZQrJqO9 IUoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wX4op3BZu/NdS4rR8C4CWFo0uWODHG3FdASEyfNSRPQ=; b=GhgReYDjNqGm2UtXZWBt35t16tYpDEs7McwM2pTtaSNkYYE+qWrxppXWCFWiO1yjZY LZN9fApebgKGCQ/9G7aEXJV1EpWSZZml2GmqMidDITPuxA0TRK131P6ATmJGAao1BumT mKQY9+Z0ITvMlChcYN0thXU6ZPHzimDc6t4PAFZt5IQKMREpyZiisyCpqzVIIVwMVeL+ RRS3691wraGFJJ2xToUqYhA3evQM80WGUO4OUaJO23sjMxoRp+2+jMnZ+Fa7OYqEfc3U nA2yNoZT4IYYQIIb+vfqbwWDjAqYNnaWFZba4wKlCFg3aIMqFJ0JTr2wxfeyWJnHrGJq 2wGA== X-Gm-Message-State: AO0yUKWAEZiCluVsSQ6J4EYs4etk8Og6HMOZiuml8eLvmcHIXqzqzktp mFVtDET+0L5mFsHjF6PuSyGcaR9ykbB5EjaFEpc= X-Google-Smtp-Source: AK7set+1OuIUkbWZOOzIE3d+rRzzCifPjQf3JSjiGUjXT7c8T7ZMID1MZbEoG4r6L/DZKiangMLFdw== X-Received: by 2002:a4a:520c:0:b0:517:86f2:c87e with SMTP id d12-20020a4a520c000000b0051786f2c87emr1060225oob.8.1675254292553; Wed, 01 Feb 2023 04:24:52 -0800 (PST) Received: from ?IPV6:2804:1b3:a7c2:1887:5d31:5c36:95c5:9e2e? ([2804:1b3:a7c2:1887:5d31:5c36:95c5:9e2e]) by smtp.gmail.com with ESMTPSA id b4-20020a4ab484000000b004fca8a11c61sm7130738ooo.3.2023.02.01.04.24.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 04:24:51 -0800 (PST) Message-ID: <2c9e84f7-bc00-4516-3690-a8b87ac1768a@linaro.org> Date: Wed, 1 Feb 2023 09:24:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [PATCH v2] C-SKY: Strip hard float abi from hard float feature. To: Xianmiao Qu , libc-alpha@sourceware.org, han_mao@linux.alibaba.com Cc: fweimer@redhat.com References: <20230127020631.77580-1-cooper.qu@linux.alibaba.com> <0c09da9c-dc9d-4843-4c6a-46c21085c4c3@linaro.org> Content-Language: en-US From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 27/01/23 22:48, Xianmiao Qu wrote: > On Fri, Jan 27, 2023 at 04:24:32PM -0300, Adhemerval Zanella Netto wrote: >> >> >> It is not clear to me why you need to use '-mfloat-abi=softfp' to check >> for soft-float ABI, since it *won't* be used to actually build glibc >> (meaning that the compiler build invocation not necessary will use the >> same ABI as the test is doing). >> > > This is for compatibility with versions prior to GCC 11. The older versions > of C-SKY GCC don't support -mfloat-abi=softfp, so the '__CSKY_HARD_FLOAT_ABI__' > is always not defined, and the expression 'defined(__CSKY_HARD_FLOAT__) && !defined(__CSKY_HARD_FLOAT_ABI__)' > which is correct for newer versions of GCC does not work for older versions. > And there doesn't seem to be an expression compitable with all versions of GCC, > so I add the check for the '-mfloat-abi=softfp' option. Right, so please add a comment that the -mfloat-abi=softfp is to check for older gcc version on the configure.ac (similar to the current one).