From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 856683858C52 for ; Fri, 29 Dec 2023 01:00:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 856683858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 856683858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=68.232.141.98 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703811642; cv=none; b=FnGgYma4SIv6p6LPqdj2mTbZuqJyBj+3HnyHrYNo8VUEmxuyoL0NBZs5fPWFLQOd2t/2IPTvvu3qvjJnG+ywT3YgIM7EGVB0yFteSMByz8Xt5jTRroUfeoMnBYDJtZg0uecMjGPzp0gJcyimlFmhpbyBlij9r7kN+U5/x7I2ymE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703811642; c=relaxed/simple; bh=lxtSN7V8UFb4CUh4WAltSRZK8deNMpGE5jgu7mxvSoM=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=jA8P5k/KhMsla9wOD38HzZcRQMHEzMbzb/VObMgLorOIicJEe2i0Vo8ZoGznQgwvYh9WBuy5KnI5oAhl3z3l+SLd7qAmSWYhTTN5XYaWI6yKYj/PJFH5x2ibjpebjB4FZFDHYHniufdUyAudwjnaZJeyAQEflp6WSab5v2+iWRs= ARC-Authentication-Results: i=1; server2.sourceware.org X-CSE-ConnectionGUID: FQHpx/+ITN++2M0q1Na1uQ== X-CSE-MsgGUID: sZxNcd3eRJmUlTiHNyh3ZA== X-IronPort-AV: E=Sophos;i="6.04,313,1695715200"; d="scan'208";a="29611817" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 28 Dec 2023 17:00:35 -0800 IronPort-SDR: gkq5EKEZt6bnSHKr0jQD03k12N9HBem7QG8To8HmJv62Hz3opzMT5oSPjD7LkGGPSI6GNpZczA 3VOCyrBRGmLQFcMZ6BKxcNLhr4NPZXK9BmBnINMyHj+QEm5zfsv8N++fCLOiZvYkl0jVRFgPXi 13+oWcnLCwrpRfvwpFBnzGJ4aiKposoS8Uz1ihsRA7eNYgowxIP2eerko6ozu7ytYs1efqOvjE +WZoqzveaNav0xdcE/gAfNm+CKG4KV3yUFFvf6plZ4C3bVcKeSWkovU7AFp6dY66+beCOc/ORe xVw= Date: Fri, 29 Dec 2023 01:00:31 +0000 From: Joseph Myers To: Junxian Zhu CC: , Subject: Re: [PATCH 2/2] MIPS: Hard-float rounding instructions support In-Reply-To: <20231225103548.1615-4-zhujunxian@oss.cipunited.com> Message-ID: <2cdc9ad4-bf63-6de9-734-3497fb9921b@codesourcery.com> References: <20231225103548.1615-2-zhujunxian@oss.cipunited.com> <20231225103548.1615-4-zhujunxian@oss.cipunited.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3108.5 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, 25 Dec 2023, Junxian Zhu wrote: > diff --git a/sysdeps/mips/mips32/Implies b/sysdeps/mips/mips32/Implies > index 6473f2517c..71b3678c6c 100644 > --- a/sysdeps/mips/mips32/Implies > +++ b/sysdeps/mips/mips32/Implies > @@ -1,3 +1,4 @@ > +mips/fpu > mips/ieee754 > mips > wordsize-32 > diff --git a/sysdeps/mips/mips64/Implies b/sysdeps/mips/mips64/Implies > index 826ff1541f..8885ebd564 100644 > --- a/sysdeps/mips/mips64/Implies > +++ b/sysdeps/mips/mips64/Implies > @@ -1,4 +1,5 @@ > # MIPS uses IEEE 754 floating point. > +mips/fpu > mips/ieee754 > ieee754/flt-32 > ieee754/dbl-64 These changes are clearly incorrect, as they would cause mips/fpu/ to be used for soft-float. The fpu/ directories are selected automatically for hard-float, and must not be used for soft-float. I'm guessing you're motivated by some ordering issue that results in the ieee754/ directories ending up being used before mips/fpu/. I'm not sure of the best way to avoid such an ordering issue (noting that the ieee754/ directories go in Implies separately for mips32 and mips64 because only mips64 uses ldbl-128), but e.g. #includes like in sysdeps/mips/mips64/n32/fpu/s_fma.c should work if you can't get the preferred sysdeps directory ordering. -- Joseph S. Myers joseph@codesourcery.com