From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x234.google.com (mail-oi1-x234.google.com [IPv6:2607:f8b0:4864:20::234]) by sourceware.org (Postfix) with ESMTPS id A09993858401 for ; Mon, 8 Nov 2021 11:39:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A09993858401 Received: by mail-oi1-x234.google.com with SMTP id u74so5897470oie.8 for ; Mon, 08 Nov 2021 03:39:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=aB8lRyVeIr9EmnL8D7OZyltULkz5xOaI28SGmV0uWGI=; b=CNI2fDCORK7UNozr03a9u566pJ3fYxAZivAjA0HAnAAzmrnp+vYRCOYFK2b7npnoFu qtQgUwTsDEZ+edKUHMLLAA4YDYCJsWWpoAFFPzYlxaTljW00hForYsBEgBx+LTEABhXV sI+xSYnaj+nIaL8TcE8E7+Ein7+3EVVXTMLFap/2oDe1gIMjpPuJ9CV+hsb8XandBjHg mq/ooh7TS0HuU1m0NDK3OocjzbRssooSK3p5D/mxVnctUbhkB1IA6NLgczd1S6ODjnFH 1nfPQqmFNXc2yvAI1rqLWxgktm/uERO2BVSTRH+pl6IOUtNEbN9ojCE8BwELzp7YPc9F oj9A== X-Gm-Message-State: AOAM531HZRvkwEhXN48yESHh4VKXTH7Z5JrCqUwAjWfMMk76AhWAXXKW cBcGweLg627JFYay3g7dn29QUgRpZ7H3YA== X-Google-Smtp-Source: ABdhPJw27EeQmdcsxVaxYMyBBzJmD9y5HwdKC5rjBJT34zjxhs902SPlvCMi5onDOlacJ4tuNh3dSQ== X-Received: by 2002:a05:6808:205:: with SMTP id l5mr4920276oie.164.1636371543039; Mon, 08 Nov 2021 03:39:03 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:55a:c067:29b:4c08:be99? ([2804:431:c7cb:55a:c067:29b:4c08:be99]) by smtp.gmail.com with ESMTPSA id q15sm6076846otk.81.2021.11.08.03.39.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Nov 2021 03:39:02 -0800 (PST) Message-ID: <2e15794f-555c-30f1-f774-f23839146da6@linaro.org> Date: Mon, 8 Nov 2021 08:39:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH] test-memcpy.c: Double TIMEOUT to (8 * 60) Content-Language: en-US To: "H.J. Lu" , libc-alpha@sourceware.org References: <20211107160829.1004634-1-hjl.tools@gmail.com> From: Adhemerval Zanella In-Reply-To: <20211107160829.1004634-1-hjl.tools@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 Nov 2021 11:39:05 -0000 On 07/11/2021 13:08, H.J. Lu via Libc-alpha wrote: > commit d585ba47fcda99fdf228e3e45a01b11a15efbc5a > Author: Noah Goldstein > Date: Mon Nov 1 00:49:48 2021 -0500 > > string: Make tests birdirectional test-memcpy.c > > This commit updates the memcpy tests to test both dst > src and dst < > src. This is because there is logic in the code based on the > > Signed-off-by: Noah Goldstein > Reviewed-by: H.J. Lu > > significantly increased the number of tests. On Intel Core i7-1165G7, > test-memcpy takes 120 seconds to run when machine is idle. Double > TIMEOUT to (8 * 60) for test-memcpy to avoid timeout when machine is > under heavy load. Shouldn't we split the test instead? If it takes 120s on a high-end chip, it might take way more in other chips. It also optimizes the testsuite, since it would allow to better use parallel builds. > --- > string/test-memcpy.c | 1 + > string/test-string.h | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/string/test-memcpy.c b/string/test-memcpy.c > index 3b0f3127b7..101d51c487 100644 > --- a/string/test-memcpy.c > +++ b/string/test-memcpy.c > @@ -22,6 +22,7 @@ > # define MIN_PAGE_SIZE 131072 > # define TEST_MAIN > # define TEST_NAME "memcpy" > +# define TIMEOUT (8 * 60) > # include "test-string.h" > > char *simple_memcpy (char *, const char *, size_t); > diff --git a/string/test-string.h b/string/test-string.h > index 8ee00a04b1..9a6b76daa4 100644 > --- a/string/test-string.h > +++ b/string/test-string.h > @@ -68,7 +68,9 @@ extern impl_t __start_impls[], __stop_impls[]; > > > # define TEST_FUNCTION test_main > -# define TIMEOUT (4 * 60) > +# ifndef TIMEOUT > +# define TIMEOUT (4 * 60) > +# endif > # define OPT_ITERATIONS 10000 > # define OPT_RANDOM 10001 > # define OPT_SEED 10002 >