From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by sourceware.org (Postfix) with ESMTPS id 1611438618F3 for ; Fri, 18 Jun 2021 18:14:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1611438618F3 Received: by mail-qv1-xf35.google.com with SMTP id 5so4021176qvf.1 for ; Fri, 18 Jun 2021 11:14:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XXoa27s2aEmmDKZq77DYfzoNTtFVOx5Unf6w1dxn17M=; b=OzCpUxaP0rVRRsBZhRlYqBnNcXuQbzPvg0KVmh4aCg1G0+rgEJE2J0Wiz4dhpJGmz/ lOCIlRYiPc2lf/lzxFamuGi/qjIAkJClPJoeuxHfRyPT325vP5AfdxUMuKgbUF39aesQ FhOAdhb6Kp76X3dWIvcTNjNlS5MybXrCGOeljg3D01E0saWR0ukei1llnEn+fbHMntiB tCXVmegQqhJfAdISNqkb+v1uftmLJD8mjDhNugOOC/wNNvMUyMk7r8AKoAMVQF5N62hI tOzmSw2DIqHCerUbIMWVAIOwGv5oQhQO8jEDRPnwBIaKSazCgjYcJt0LNvjsNO2nbPgO ZIKA== X-Gm-Message-State: AOAM530J+ZUMVbqLaUhO0leWYbP6mYW9HQ5Tlia/4Qi8/bUXWm3obo1G xB1mJQYOXnTww/3MbAI0Jb/Dbw== X-Google-Smtp-Source: ABdhPJxp1aQGr6OPabzsYx5sDk/QvvBZch7dY9K5+o14PPPj5Ay6drqdj9TZ8AM8wbutd+FhQ7zKFg== X-Received: by 2002:a0c:c30e:: with SMTP id f14mr7164883qvi.19.1624040087682; Fri, 18 Jun 2021 11:14:47 -0700 (PDT) Received: from [192.168.1.108] ([177.194.59.218]) by smtp.gmail.com with ESMTPSA id k124sm4406858qkc.132.2021.06.18.11.14.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jun 2021 11:14:47 -0700 (PDT) Subject: Re: [PATCH 02/18] Use LFS and 64 bit time for installed programs To: Joseph Myers Cc: libc-alpha@sourceware.org, Lukasz Majewski , Carlos O'Donell References: <20210617115104.1359598-1-adhemerval.zanella@linaro.org> <20210617115104.1359598-3-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Message-ID: <2e7adb20-c6d7-3ff3-2d62-f14d21364a6d@linaro.org> Date: Fri, 18 Jun 2021 15:14:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 18:14:49 -0000 On 17/06/2021 17:49, Joseph Myers wrote: > On Thu, 17 Jun 2021, Adhemerval Zanella via Libc-alpha wrote: > >> The installed programs are built with a combination of different >> values for MODULE_NAME, as below. To enable both Long File Support >> and 64 bt time, -D_TIME_BITS=64 -D_FILE_OFFSET_BITS=64 is added for >> nonlib, nscd, lddlibc4, ldconfig, locale_programs, and iconvprogs >> modules. > > Using 64-bit filesystem interfaces in installed programs is bug 15333. > > Does this patch fix all instances where an installed program, on a 32-bit > system, might end up using 32-bit filesystem or time interfaces (including > any cases where APIs used in the programs need to change to fix things, > e.g. any uses of fseek/ftell that need to become fseeko / ftello with use > of off_t instead of long), or are there further cases left to be fixed? > It seems that this patch still misses some non LFS usages: time32: : /lib/libmemusage.so: setitimer non-lfs: : /lib/libnss_files-2.33.9000.so: fsetpos non-lfs: : /lib/libnss_files-2.33.9000.so: fgetpos non-lfs: : /lib/libutil-2.33.9000.so: open non-lfs: : /lib/libmemusage.so: mmap non-lfs: : /lib/libmemusage.so: lseek non-lfs: : /lib/libnss_compat-2.33.9000.so: fsetpos non-lfs: : /lib/libnss_compat-2.33.9000.so: fgetpos non-lfs: : /lib/libSegFault.so: open non-lfs: : /lib/libnss_db-2.33.9000.so: mmap non-lfs: : /lib/libpcprofile.so: open non-lfs: : /lib/libnss_hesiod-2.33.9000.so: fopen non-lfs: : /lib/libresolv-2.33.9000.so: fopen non-lfs: : /usr/lib/audit/sotruss-lib.so: fcntl non-lfs: : /usr/lib/audit/sotruss-lib.so: open I will send an updated version.