* [PATCH] math: $(libm-tests-compat) can be regular tests
@ 2021-03-04 16:04 Florian Weimer
2021-03-08 14:06 ` Adhemerval Zanella
0 siblings, 1 reply; 2+ messages in thread
From: Florian Weimer @ 2021-03-04 16:04 UTC (permalink / raw)
To: libc-alpha
tests-internal is no longer needed because compat_symbol_reference
now works in regular tests.
---
math/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/math/Makefile b/math/Makefile
index 687aa5d510..2978abf526 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -325,8 +325,7 @@ libm-tests-for-type = $(foreach f,$(libm-test-funcs-all),\
libm-tests.o = $(addsuffix .o,$(libm-tests))
-tests += $(filter-out $(libm-tests-compat),$(libm-tests))
-tests-internal += $(libm-tests-compat)
+tests += $(libm-tests)
generated += $(addsuffix .c,$(libm-tests)) \
$(foreach t,$(test-types),libm-test-support-$(t).c)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] math: $(libm-tests-compat) can be regular tests
2021-03-04 16:04 [PATCH] math: $(libm-tests-compat) can be regular tests Florian Weimer
@ 2021-03-08 14:06 ` Adhemerval Zanella
0 siblings, 0 replies; 2+ messages in thread
From: Adhemerval Zanella @ 2021-03-08 14:06 UTC (permalink / raw)
To: libc-alpha
On 04/03/2021 13:04, Florian Weimer via Libc-alpha wrote:
> tests-internal is no longer needed because compat_symbol_reference
> now works in regular tests.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> math/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/math/Makefile b/math/Makefile
> index 687aa5d510..2978abf526 100644
> --- a/math/Makefile
> +++ b/math/Makefile
> @@ -325,8 +325,7 @@ libm-tests-for-type = $(foreach f,$(libm-test-funcs-all),\
>
> libm-tests.o = $(addsuffix .o,$(libm-tests))
>
> -tests += $(filter-out $(libm-tests-compat),$(libm-tests))
> -tests-internal += $(libm-tests-compat)
> +tests += $(libm-tests)
> generated += $(addsuffix .c,$(libm-tests)) \
> $(foreach t,$(test-types),libm-test-support-$(t).c)
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-08 14:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-04 16:04 [PATCH] math: $(libm-tests-compat) can be regular tests Florian Weimer
2021-03-08 14:06 ` Adhemerval Zanella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).