From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by sourceware.org (Postfix) with ESMTPS id B3FC0385843E for ; Thu, 23 Sep 2021 13:08:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B3FC0385843E Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 999B35C00ED; Thu, 23 Sep 2021 09:08:56 -0400 (EDT) Received: from imap45 ([10.202.2.95]) by compute1.internal (MEProxy); Thu, 23 Sep 2021 09:08:56 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudeiledgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefofgggkfgjfhffhffvufgtgfesth hqredtreerjeenucfhrhhomhepfdgkrggtkhcuhggvihhnsggvrhhgfdcuoeiirggtkhes ohiflhhfohhlihhordhorhhgqeenucggtffrrghtthgvrhhnpeffteffkeehfeevhedule ekheeugfekjedtgfejvdefueeujeeghfeuieeijeekfeenucevlhhushhtvghrufhiiigv pedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpeiirggtkhesohiflhhfohhlihhordhorh hg X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 4912224A0067; Thu, 23 Sep 2021 09:08:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-1303-gb2406efd75-fm-20210922.002-gb2406efd Mime-Version: 1.0 Message-Id: <2eeb347c-f8d9-48ac-b733-d67c0a25ee47@www.fastmail.com> In-Reply-To: <874kabit3u.fsf@igel.home> References: <20210923071719.315444-1-maskray@google.com> <87ilyriukg.fsf@igel.home> <20210923081707.uyvyq652pjqhl7tu@google.com> <874kabit3u.fsf@igel.home> Date: Thu, 23 Sep 2021 09:08:35 -0400 From: "Zack Weinberg" To: libc-alpha@sourceware.org, "Fangrui Song" Subject: =?UTF-8?Q?Re:_[PATCH_v2]_elf:_Avoid_nested_functions_in_the_loader_(all_?= =?UTF-8?Q?ports)_[BZ_#27220]?= Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Sep 2021 13:09:00 -0000 On Thu, Sep 23, 2021, at 4:39 AM, Andreas Schwab wrote: > On Sep 23 2021, Fangrui Song wrote: > >> What do you mean by at the top? > > The opposite of bottom. In actually helpful terms, please put the #define for the guard macro im= mediately after the matching #ifndef. That=E2=80=99s how all the other h= eaders do it. zw