From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 08BD0392AC38 for ; Mon, 5 Dec 2022 15:56:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 08BD0392AC38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670255794; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LTZPM+G3JGB1CZ0N1Z4fwQkIyVQXWxRkxltSY5IkYtg=; b=D1AOv0VgRe+rW9StOnf6B0iB8sZ0ZfpR61GtuqXOetEsPTqHnpnCs4S/34vqpe0V7P9Ikr 00O9OpsiEUzCMXYUDEOKGz2rpM+TN6hZXb6ua+8DUGXjB52MWSlVecMJxDOZpFW81qMe2w 4zkJ4UGicwPgll9HyjXUbZ9afDMI9WA= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-529-R6rVQNECNAW3rxC2kq8e9g-1; Mon, 05 Dec 2022 10:56:33 -0500 X-MC-Unique: R6rVQNECNAW3rxC2kq8e9g-1 Received: by mail-io1-f70.google.com with SMTP id l22-20020a05660227d600b006dfa191ca8aso10103114ios.20 for ; Mon, 05 Dec 2022 07:56:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LTZPM+G3JGB1CZ0N1Z4fwQkIyVQXWxRkxltSY5IkYtg=; b=Dtt7WMRnIRvaT1LZp6Q/i5D+Wjfnvx2QauFFBcMyuJ9GLb7RVT5FaGxM1jtSf5QbRi chNk1deDh3Dmj7eyY6ZqJRz3zMuVw6sXvshMow5JZF1NDSPnkraWwM4CqsrfS0VmY7TS px3uFBkEaNGyKdYTQEPiHyA5XHyhdMTaPZd75il9ReEm1vEzmetiu+4yETFGv5EFuJB8 jYbNBqX4/8TTAXAwclUtuRhXZeVSek3V2kf8Dbem9a5m8IUY+mOhPWmhFL5Zn9jiDWTE BThXbprHuZYwdM1nwCSdXywYU928kV8ExNaFAaBUubIonLwGTqO6t6h+fxw9QnQSCzTl +dqA== X-Gm-Message-State: ANoB5plqlUhuwC450WakTirbKXarGUZIk5Pxk3TQEjDuLMx3Fh0kZavd zJMLYglaLfZStEswZjSrBXAQt00fdYYbE2Rkqqx/H/JRR2XY0+++216z5IhgYUDGOewn/ZauGLP hizUDT1b2MSAJMtYMvijt X-Received: by 2002:a05:6e02:58c:b0:303:a45:573a with SMTP id c12-20020a056e02058c00b003030a45573amr18558455ils.1.1670255792818; Mon, 05 Dec 2022 07:56:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf4etg2EzJztWUbvvA+Nbv+X71bwX9Nac05Mc0FLj2Ivv06ctOjFLmgxIvVS9iydOH33QDdbbQ== X-Received: by 2002:a05:6e02:58c:b0:303:a45:573a with SMTP id c12-20020a056e02058c00b003030a45573amr18558450ils.1.1670255792545; Mon, 05 Dec 2022 07:56:32 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id d39-20020a026067000000b00389e42ac620sm5814739jaf.129.2022.12.05.07.56.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 07:56:32 -0800 (PST) Message-ID: <2f0cb8b2-ef12-29ee-a8d1-a53d2255202b@redhat.com> Date: Mon, 5 Dec 2022 10:56:31 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 4/6] configure: Remove AS check To: Adhemerval Zanella , libc-alpha@sourceware.org, Vineet Gupta , =?UTF-8?Q?Ludovic_Court=c3=a8s?= References: <20221202190030.1671870-1-adhemerval.zanella@linaro.org> <20221202190030.1671870-5-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221202190030.1671870-5-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/2/22 14:00, Adhemerval Zanella via Libc-alpha wrote: > The assembler is not issued directly, but rather always through CC > wrapper. The binutils version check if done with LD instead. glibc needs binutils 2.25 or newer in general, and the linker check is sufficient to test for that. Other architectures may have specific requirements and they need to enforce that distinctly, like the ppc64le objcopy test. For AS we really only want to use $(CC) -c, so testing distinctly isn't valuable. LGTM. Reviewed-by: Carlos O'Donell > --- > aclocal.m4 | 1 - > configure | 66 ------------------------------------ > configure.ac | 5 --- > scripts/build-many-glibcs.py | 1 - > sysdeps/x86/configure | 4 +-- > sysdeps/x86/configure.ac | 2 +- > 6 files changed, 3 insertions(+), 76 deletions(-) > > diff --git a/aclocal.m4 b/aclocal.m4 > index 88db64a683..7ab8ac023b 100644 > --- a/aclocal.m4 > +++ b/aclocal.m4 > @@ -118,7 +118,6 @@ case "$CC" in > *fuse-ld=lld*) LDNAME=ld.lld;; > *) LDNAME=ld;; > esac > -AS=`$CC -print-prog-name=as` OK. > LD=`$CC -print-prog-name=$LDNAME` > AR=`$CC -print-prog-name=ar` > AC_SUBST(AR) > diff --git a/configure b/configure > index 086d6fba7a..62c2581cb0 100755 > --- a/configure > +++ b/configure OK. Regenerate. > @@ -654,7 +654,6 @@ MAKEINFO > MSGFMT > MAKE > LD > -AS > GPROF > OBJCOPY > AR > @@ -4146,7 +4145,6 @@ case "$CC" in > *fuse-ld=lld*) LDNAME=ld.lld;; > *) LDNAME=ld;; > esac > -AS=`$CC -print-prog-name=as` OK. > LD=`$CC -print-prog-name=$LDNAME` > AR=`$CC -print-prog-name=ar` > > @@ -4157,70 +4155,6 @@ GPROF=`$CC -print-prog-name=gprof` > > > # Accept binutils 2.25 or newer. > -for ac_prog in $AS > -do > - # Extract the first word of "$ac_prog", so it can be a program name with args. > -set dummy $ac_prog; ac_word=$2 > -{ $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5 > -$as_echo_n "checking for $ac_word... " >&6; } > -if ${ac_cv_prog_AS+:} false; then : > - $as_echo_n "(cached) " >&6 > -else > - if test -n "$AS"; then > - ac_cv_prog_AS="$AS" # Let the user override the test. > -else > -as_save_IFS=$IFS; IFS=$PATH_SEPARATOR > -for as_dir in $PATH > -do > - IFS=$as_save_IFS > - test -z "$as_dir" && as_dir=. > - for ac_exec_ext in '' $ac_executable_extensions; do > - if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then > - ac_cv_prog_AS="$ac_prog" > - $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext" >&5 > - break 2 > - fi > -done > - done > -IFS=$as_save_IFS > - > -fi > -fi > -AS=$ac_cv_prog_AS > -if test -n "$AS"; then > - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $AS" >&5 > -$as_echo "$AS" >&6; } > -else > - { $as_echo "$as_me:${as_lineno-$LINENO}: result: no" >&5 > -$as_echo "no" >&6; } > -fi > - > - > - test -n "$AS" && break > -done > - > -if test -z "$AS"; then > - ac_verc_fail=yes > -else > - # Found it, now check the version. > - { $as_echo "$as_me:${as_lineno-$LINENO}: checking version of $AS" >&5 > -$as_echo_n "checking version of $AS... " >&6; } > - ac_prog_version=`$AS --version 2>&1 | sed -n 's/^.*GNU assembler.* \([0-9]*\.[0-9.]*\).*$/\1/p'` > - case $ac_prog_version in > - '') ac_prog_version="v. ?.??, bad"; ac_verc_fail=yes;; > - 2.1[0-9][0-9]*|2.2[5-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*) > - ac_prog_version="$ac_prog_version, ok"; ac_verc_fail=no;; > - *) ac_prog_version="$ac_prog_version, bad"; ac_verc_fail=yes;; > - > - esac > - { $as_echo "$as_me:${as_lineno-$LINENO}: result: $ac_prog_version" >&5 > -$as_echo "$ac_prog_version" >&6; } > -fi > -if test $ac_verc_fail = yes; then > - AS=: critic_missing="$critic_missing as" > -fi > - > - > libc_cv_with_lld=no > case $($LD --version) in > "GNU gold"*) > diff --git a/configure.ac b/configure.ac > index 5709c7a0cf..022b8f68bc 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -572,11 +572,6 @@ AC_PROG_LN_S > LIBC_PROG_BINUTILS > > # Accept binutils 2.25 or newer. > -AC_CHECK_PROG_VER(AS, $AS, --version, > - [GNU assembler.* \([0-9]*\.[0-9.]*\)], > - [2.1[0-9][0-9]*|2.2[5-9]*|2.[3-9][0-9]*|[3-9].*|[1-9][0-9]*], > - AS=: critic_missing="$critic_missing as") > - OK. > libc_cv_with_lld=no > case $($LD --version) in > "GNU gold"*) ... OK leaves the ld testing in place. > diff --git a/scripts/build-many-glibcs.py b/scripts/build-many-glibcs.py > index 5af6f369ae..9292a0d3ff 100755 > --- a/scripts/build-many-glibcs.py > +++ b/scripts/build-many-glibcs.py > @@ -1522,7 +1522,6 @@ class GlibcPolicyDefault(object): > 'CC=%s' % glibc.tool_name('gcc'), > 'CXX=%s' % glibc.tool_name('g++'), > 'AR=%s' % glibc.tool_name('ar'), > - 'AS=%s' % glibc.tool_name('as'), OK. Don't override AS since we don't support that anymore. > 'LD=%s' % glibc.tool_name('ld'), > 'NM=%s' % glibc.tool_name('nm'), > 'OBJCOPY=%s' % glibc.tool_name('objcopy'), > diff --git a/sysdeps/x86/configure b/sysdeps/x86/configure > index a9c8c2ef67..f80fedd9dd 100644 > --- a/sysdeps/x86/configure > +++ b/sysdeps/x86/configure OK. Regenerate. > @@ -33,8 +33,8 @@ $as_echo "$libc_cv_x86_cet_available" >&6; } > fi > if test $enable_cet != no; then > # Check if assembler supports CET. > - { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether $AS supports CET" >&5 > -$as_echo_n "checking whether $AS supports CET... " >&6; } > + { $as_echo "$as_me:${as_lineno-$LINENO}: checking whether compiler supports CET" >&5 > +$as_echo_n "checking whether compiler supports CET... " >&6; } > if ${libc_cv_x86_cet_as+:} false; then : > $as_echo_n "(cached) " >&6 > else > diff --git a/sysdeps/x86/configure.ac b/sysdeps/x86/configure.ac > index edd43a2551..ac55dc674a 100644 > --- a/sysdeps/x86/configure.ac > +++ b/sysdeps/x86/configure.ac > @@ -22,7 +22,7 @@ EOF > fi > if test $enable_cet != no; then > # Check if assembler supports CET. > - AC_CACHE_CHECK(whether $AS supports CET, > + AC_CACHE_CHECK(whether compiler supports CET, OK. True we invoke the test via the compiler. > libc_cv_x86_cet_as, [dnl > cat > conftest.s < incsspd %ecx -- Cheers, Carlos.