public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Alejandro Colomar <alx.manpages@gmail.com>
To: наб <nabijaczleweli@nabijaczleweli.xyz>
Cc: GNU C Library <libc-alpha@sourceware.org>,
	Siddhesh Poyarekar <siddhesh@gotplt.org>
Subject: Re: regexec(3): REG_STARTEND is not documented
Date: Fri, 21 Apr 2023 03:28:42 +0200	[thread overview]
Message-ID: <2f3a3aa5-9e01-8f46-7b98-de03cf304aad@gmail.com> (raw)
In-Reply-To: <vsmudq4ypkiwcehfoea2hx3slesrfczj3kwsnxzhnqbeaxoyir@dfzeeysxvhle>


[-- Attachment #1.1: Type: text/plain, Size: 3695 bytes --]

Hi наб!

On 4/21/23 03:15, наб wrote:
> On Fri, Apr 21, 2023 at 03:07:00AM +0200, Alejandro Colomar wrote:
>> On 4/21/23 02:45, Alejandro Colomar wrote:
>>> Is the following call valid, or is it UB?
>>>     regmatch_t  pmatch = {
>>>         .rm_so = string,
>>>         .rm_eo = string + 42,  // Assume this offset is valid
>>>     };
>>>     regexec(preg, string, 0, pmatch, REG_NOSUB | REG_STARTEND);
>>> How about this?
>>>     regexec(preg, string, 999, pmatch, REG_NOSUB | REG_STARTEND);
> (If you make that "&pmatch",
>  and put the REG_NOSUB into a preceding regcomp(), my bet is on "valid".)

D'oh!  I should check what I write before putting it in a bottle.
Yeah, I meant that, or at least should have meant that :)

> 
>>> Current implementations will work, because nmatch is effectively
>>> ignored.  But is it intended to be this way, or just an implementation
>>> detail?
> My bet is on "intended", quoth 4.4BSD-Lite regex(3):
>   REG_STARTEND  The   string   is   considered   to   start  at  string +
>                 pmatch[0].rm_so and to have a terminating NUL located  at
>                 string +  pmatch[0].rm_eo  (there  need not actually be a
>                 NUL at that location), regardless of the value of nmatch.
>                 See  below for the definition of pmatch and nmatch.  This
>                 is an extension, compatible with  but  not  specified  by
>                 POSIX 1003.2, and should be used with caution in software
>                 intended to be portable to other systems.   Note  that  a
>                 non-zero  rm_so  does  not imply REG_NOTBOL; REG_STARTEND
>                 affects only the location of the string, not  how  it  is
>                 matched.

While this paragraph is not crystal clear to me, the one you quoted below
pretty much is.

> 
>> Here's a related question:
>>     regmatch_t  pmatch = {
>>         .rm_so = string,
>>         .rm_eo = string + 42,  // Assume this offset is valid
>>     };
>>     regexec(preg, string, 0, pmatch, REG_STARTEND);
>> Should regexec(3) write to the 1st element in pmatch[] because it knows
>> it exists (otherwise the call would be UB because it needs to read it)?
> (Which would run counter to how POSIX defines the API.)
> 
>> Or is passing 0 in nmatch effectively another way of performing
>> REG_NOSUB behavior without actually using the flag?
> Hilariously enough, quoth 4.4BSD-Lite regex(3) again,
> which phrases it exactly like you do:
>   If  REG_NOSUB  was specified in the compilation of the RE, or if nmatch
>   is 0, regexec ignores the pmatch argument (but see below for  the  case
>   where REG_STARTEND is specified).

Touche; it looks like your right.  That sentence is unambiguous.  BTW, is the
reference to some other text about REG_STARTEND the one quoted first
(above)?

Cheers,
Alex

>  Otherwise, pmatch points to an array
>   of nmatch structures of type regmatch_t.  Such a structure has at least
>   the members rm_so and rm_eo, both of type regoff_t (a signed arithmetic
>   type at least as large as an off_t and a ssize_t),  containing  respec‐
>   tively  the offset of the first character of a substring and the offset
>   of the first character after the end of  the  substring.   Offsets  are
>   measured  from  the  beginning of the string argument given to regexec.
>   An empty substring is denoted by equal  offsets,  both  indicating  the
>   character following the empty substring.
> (you know how I'm betting here).

:)

> 
> наб

-- 
<http://www.alejandro-colomar.es/>
GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-04-21  1:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21  0:45 Alejandro Colomar
2023-04-21  1:07 ` Alejandro Colomar
2023-04-21  1:15   ` наб
2023-04-21  1:28     ` Alejandro Colomar [this message]
2023-04-21  1:41       ` наб
2023-04-21  1:47         ` Alejandro Colomar
2023-04-21 11:59 ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f3a3aa5-9e01-8f46-7b98-de03cf304aad@gmail.com \
    --to=alx.manpages@gmail.com \
    --cc=libc-alpha@sourceware.org \
    --cc=nabijaczleweli@nabijaczleweli.xyz \
    --cc=siddhesh@gotplt.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).