From: Ivo Raisr <ivo.raisr@oracle.com>
To: libc-alpha@sourceware.org
Cc: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Subject: Re: [PATCH 2/6] Move mutex and condition variable definition to common header
Date: Wed, 22 Mar 2017 22:59:00 -0000 [thread overview]
Message-ID: <2f4ff9ac-5db2-2372-e038-921d0244fcd5@oracle.com> (raw)
In-Reply-To: <1490103612-9401-3-git-send-email-adhemerval.zanella@linaro.org>
Thank you for the patches.
See my comment below.
I.
On 21.3.2017 14:40, Adhemerval Zanella wrote:
> This patch sorts out pthread_mutex_t and pthread_cond_t in new files,
> so new C11 types could be based on pthread types without corrupting
> namespaces and exposing pthread symbols.
...
>
> diff --git a/bits/thread-shared-types.h b/bits/thread-shared-types.h
> new file mode 100644
> index 0000000..98f2084
> --- /dev/null
> +++ b/bits/thread-shared-types.h
> +/* This file is required to have a shared types definition
> + between POSIX threads and C11 threads. It allows to
> + header files like pthread.h and thread.h to define their types
> + with the same size and fields without corrupting namespaces.
Typo here. I'd suggest:
- between POSIX threads and C11 threads. It allows to
+ between POSIX threads and C11 threads. It allows
next prev parent reply other threads:[~2017-03-22 22:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 13:40 [PATCH v3 0/6] Add support for ISO C11 threads.h Adhemerval Zanella
2017-03-21 13:40 ` [PATCH 4/6] Add C11 threads support Adhemerval Zanella
2017-03-21 13:40 ` [PATCH 3/6] Clean pthread functions namespaces for C11 threads Adhemerval Zanella
2017-03-21 13:40 ` [PATCH 1/6] Consolidate pthreadtype.h placement Adhemerval Zanella
2017-03-21 13:48 ` Andreas Schwab
2017-03-21 15:07 ` Adhemerval Zanella
2017-03-21 13:40 ` [PATCH 6/6] Add manual documentation for threads.h Adhemerval Zanella
2017-03-21 13:40 ` [PATCH 5/6] Add test cases for ISO C11 threads Adhemerval Zanella
2017-03-21 13:40 ` [PATCH 2/6] Move mutex and condition variable definition to common header Adhemerval Zanella
2017-03-22 22:59 ` Ivo Raisr [this message]
2017-03-27 13:43 ` Torvald Riegel
2017-03-27 14:25 ` Adhemerval Zanella
2017-03-28 8:19 ` Torvald Riegel
2017-03-31 13:43 ` Adhemerval Zanella
2017-03-21 16:25 ` [PATCH v3 0/6] Add support for ISO C11 threads.h Joseph Myers
2017-03-21 16:44 ` Adhemerval Zanella
2017-03-21 16:49 ` Joseph Myers
2017-03-21 17:08 ` Adhemerval Zanella
2017-03-21 20:10 ` Adhemerval Zanella
2017-03-27 13:29 ` Torvald Riegel
2017-03-27 13:29 ` Torvald Riegel
2017-03-27 16:10 ` Martin Sebor
2017-03-28 8:08 ` Torvald Riegel
2017-03-31 13:39 ` Adhemerval Zanella
2017-04-06 11:05 ` Torvald Riegel
2017-04-06 14:30 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f4ff9ac-5db2-2372-e038-921d0244fcd5@oracle.com \
--to=ivo.raisr@oracle.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).