Re: [PATCH v2 01/12] Simplify allocations and fix merge and continue actions [BZ #28931]

[Siddhesh Poyarekar <siddhesh@sourceware.org>]

On 17/03/2022 02:17, DJ Delorie wrote:
>> +static void
>> +prepare (int argc, char **argv)
>> +{
>> +  chroot_env = support_chroot_create
>> +    ((struct support_chroot_configuration)
>> +     {
>> +       .resolv_conf = "",
>> +       .hosts = "",
>> +       .host_conf = "multi on\n",
>> +     });
>> +}
> 
> I'm curious why you chose to go this route rather than using the
> test-container framework, which would have done most of this for you?
> (but ok)

I had initially written this test with dns *and* files modules and the 
former required me to stay out of the container.  Now that the dns 
module bit is gone, I could put it back into a container.

I'll respin this patch because...

> 
>> +/* Create the /etc/hosts file from outside the chroot.  */
>> +static void
>> +write_hosts (void)
>> +{
>> +  const int count = 512;
>> +
>> +  FILE *fp = xfopen (chroot_env->path_hosts, "w");
>> +  fputs ("127.0.0.1   localhost localhost.localdomain\n"
>> +         "::1         localhost localhost.localdomain\n",
>> +         fp);
>> +  for (int i = 1; i < count; ++i)
>> +    fprintf (fp, "192.0.%d.%d gnu.org\n", (i / 256) & 0xff, i & 0xff);
> 
> That's a lot of gnu.org :-)

... Andreas suggested that I replace this with example.org.

Thanks,
Siddhesh