From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 4D02B385DC35 for ; Wed, 22 Apr 2020 14:59:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4D02B385DC35 Received: from pps.filterd (m0098410.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 03MEXPCo083794 for ; Wed, 22 Apr 2020 10:59:08 -0400 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 30ggxratmu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Apr 2020 10:59:08 -0400 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.27/8.16.0.27) with SMTP id 03MEu5FW031004 for ; Wed, 22 Apr 2020 14:59:06 GMT Received: from b03cxnp08025.gho.boulder.ibm.com (b03cxnp08025.gho.boulder.ibm.com [9.17.130.17]) by ppma01wdc.us.ibm.com with ESMTP id 30fs66a68j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 22 Apr 2020 14:59:06 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp08025.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 03MEx5ZS53805464 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 22 Apr 2020 14:59:06 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDC78C6057 for ; Wed, 22 Apr 2020 14:59:05 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9625AC6067 for ; Wed, 22 Apr 2020 14:59:05 +0000 (GMT) Received: from [9.85.170.199] (unknown [9.85.170.199]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP for ; Wed, 22 Apr 2020 14:59:05 +0000 (GMT) Subject: Re: [PATCH v3 2/6] Rename __LONG_DOUBLE_USES_FLOAT128 to __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI To: libc-alpha@sourceware.org References: <051ed553501de83ffdf59ac09dd2a73c29f69343.1586199342.git.murphyp@linux.vnet.ibm.com> From: Paul E Murphy Message-ID: <2fc48d3a-9d96-fab9-c779-74a6a1dc0784@linux.ibm.com> Date: Wed, 22 Apr 2020 09:59:04 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138, 18.0.676 definitions=2020-04-22_06:2020-04-22, 2020-04-22 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 suspectscore=0 lowpriorityscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 spamscore=0 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004220116 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00, BODY_8BITS, GIT_PATCH_2, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2020 14:59:11 -0000 On 4/15/20 9:21 AM, Paul E Murphy via Libc-alpha wrote: > > > On 4/6/20 2:12 PM, Paul E. Murphy via Libc-alpha wrote: >> per feedback and disucssion on libc-alpha [2].  Likewise, add >> documentation to the macro in the common bits/long-double.h header. >> This is effectively V2 of [2]. >> >> Per the feedback from Joseph [1].  Good comments and a more >> self-explanatory macro name will be very helpful when this >> macro is able to assume a non-zero value. >> >> [1] >> [2] >> >> >> ---8<--- >> >> Improve the commentary to aid future developers who will stumble >> upon this novel, yet not always perfect, mechanism to support >> alternative formats for long double. >> >> Likewise, rename __LONG_DOUBLE_USES_FLOAT128 to >> __LDOUBLE_REDIRECTS_TO_FLOAT128_ABI now that development work >> has settled down.  The command used was >> >> git grep -l __LONG_DOUBLE_USES_FLOAT128 ':!./ChangeLog*' | \ >>    xargs sed -i >> 's/__LONG_DOUBLE_USES_FLOAT128/__LDOUBLE_REDIRECTS_TO_FLOAT128_ABI/g' >> --- >>   argp/argp.h                                       |  2 +- >>   bits/long-double.h                                | 15 ++++++++++++++- >>   elf/tst-addr1.c                                   |  2 +- >>   include/math.h                                    |  6 +++--- >>   include/monetary.h                                |  2 +- >>   include/printf.h                                  |  2 +- >>   include/stdio.h                                   |  8 ++++---- >>   include/stdlib.h                                  |  4 ++-- >>   include/sys/cdefs.h                               |  2 +- >>   include/wchar.h                                   |  2 +- >>   libio/bits/stdio-ldbl.h                           |  4 ++-- >>   libio/stdio.h                                     |  8 ++++---- >>   math/complex.h                                    |  4 ++-- >>   math/math.h                                       | 12 ++++++------ >>   math/test-ldouble.h                               |  2 +- >>   misc/err.h                                        |  2 +- >>   misc/error.h                                      |  2 +- >>   misc/sys/cdefs.h                                  |  4 ++-- >>   misc/sys/syslog.h                                 |  2 +- >>   stdio-common/printf.h                             |  2 +- >>   stdio-common/tst-vfprintf-user-type.c             |  2 +- >>   stdlib/bits/stdlib-ldbl.h                         |  2 +- >>   stdlib/monetary.h                                 |  2 +- >>   stdlib/stdlib.h                                   |  2 +- >>   sysdeps/ieee754/ldbl-128/bits/long-double.h       |  2 +- >>   .../ieee754/ldbl-128ibm-compat/bits/long-double.h |  7 ++----- >>   sysdeps/ieee754/ldbl-128ibm-compat/math_ldbl.h    |  2 +- >>   sysdeps/ieee754/ldbl-128ibm/bits/iscanonical.h    |  2 +- >>   sysdeps/ieee754/ldbl-128ibm/ieee754.h             |  6 +++--- >>   .../ldbl-128ibm/include/bits/iscanonical.h        |  2 +- >>   sysdeps/ieee754/ldbl-96/bits/long-double.h        |  2 +- >>   sysdeps/ieee754/ldbl-opt/bits/long-double.h       |  2 +- >>   sysdeps/mips/ieee754/bits/long-double.h           |  2 +- >>   .../sysv/linux/sparc/sparc32/bits/long-double.h   |  2 +- >>   .../sysv/linux/sparc/sparc64/bits/long-double.h   |  2 +- >>   wcsmbs/bits/wchar-ldbl.h                          |  4 ++-- >>   wcsmbs/wchar.h                                    |  8 ++++---- >>   37 files changed, 74 insertions(+), 64 deletions(-) > > Ping? Ping. I will commit this friday pending no additional feedback.