From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 9B846385502B for ; Mon, 28 Jun 2021 12:31:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B846385502B Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-172-TxPokFI0P3S89MzDX--W5A-1; Mon, 28 Jun 2021 08:30:59 -0400 X-MC-Unique: TxPokFI0P3S89MzDX--W5A-1 Received: by mail-qt1-f199.google.com with SMTP id s20-20020ac85cd40000b029024ebedff900so12619853qta.10 for ; Mon, 28 Jun 2021 05:30:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=wFhPCkgr6IfXKxu9DtKgn9zn910zCL7JzOhGw4l7RMQ=; b=gp88vPD/A6wWqn34cJ3fl/gSK5jUniZHRm7AwcNHugPrxqKJVGWtsQozOerhErGVRd OdTVY3XaKn02VuCK0gqi8p5LJS+jSISiWu3eUchux8QW4pb+ZnDWZ8c723PRL4G8HqlN J0hxy+SDTDnjNY2IyXC+sxiq3LBjD6IZEu1bstmQvj5A73pTQ/PNmKN/b4AblYCSCqF/ Gx2nc33aiYF37ZccdP+Bs7W6NDBcMc2cSKRTo2H5ynu5SgHN/SUY2KcQLSkpwPhWyGPP TyGynTpDV4Pu4yscFqROKGpHLWX3ZRx8ISc2egebDqWhbpPw0+n5Nim5Taf4x99/WWwL SEyg== X-Gm-Message-State: AOAM532Y55oCPYu5sc+zoZPyHT5M4kZnBZZFhujAVzMKTPDpaZW18nvr rDeGM91VgW5yMBmw2SMAPVaojnrcDyGSTH9DNB+r85vBS9x01UEjPznydeKvVduSpJ9wZwwA/rI qYNA8s/mNi+dlLCcBjwZhYIoLEwxyKO1aEcMMjetCPAxIAvwZEwZhZQRjZ1RK5N2zFz5uTw== X-Received: by 2002:ad4:4f0a:: with SMTP id fb10mr25483860qvb.51.1624883458829; Mon, 28 Jun 2021 05:30:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwoPn1riDsun2f+8qxNQ/WrP4Sj8s3gynUqCM11F9h0Y0F6lgqmFT2xf6U5Cc28KD4aVVQgYQ== X-Received: by 2002:ad4:4f0a:: with SMTP id fb10mr25483838qvb.51.1624883458559; Mon, 28 Jun 2021 05:30:58 -0700 (PDT) Received: from [192.168.1.16] (198-84-214-74.cpe.teksavvy.com. [198.84.214.74]) by smtp.gmail.com with ESMTPSA id u66sm3423766qkc.89.2021.06.28.05.30.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Jun 2021 05:30:57 -0700 (PDT) Subject: Re: [PATCH 0/3] ntpl: Export libthread_db-used symbols (v2) To: Florian Weimer , libc-alpha@sourceware.org References: From: Carlos O'Donell Organization: Red Hat Message-ID: <303c06b6-63c9-43e8-1da3-18976ab967f3@redhat.com> Date: Mon, 28 Jun 2021 08:30:57 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jun 2021 12:31:02 -0000 On 6/28/21 5:09 AM, Florian Weimer via Libc-alpha wrote: > This incorporates Carlos' feedback and adds more symbol tests to the > GLIBC_PRIVATE consistency check. > > Tested on x86_64-linux-gnu, i686-linux-gnu, built with > build-many-glibcs.py. Not yet tested with GDB. Thanks for moving this forward, and ensuring that the additional symbols help ensure that gdb can handle the new integration of libpthread into libc. > Florian Weimer (3): > nptl_db: Clean up main/rtld variable handling > nptl: Rename nptl_version to __nptl_version > nptl: Export libthread_db-used symbols under GLIBC_PRIVATE > > nptl/Versions | 58 ++++++++++++++++++++++++++++++++++++++++++ > nptl/pthread_create.c | 13 ++++++---- > nptl_db/Makefile | 2 +- > nptl_db/db-symbols.awk | 17 ++++++++++--- > nptl_db/structs.def | 16 +++++------- > nptl_db/td_ta_new.c | 2 +- > 6 files changed, 88 insertions(+), 20 deletions(-) > -- Cheers, Carlos.