From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82a.google.com (mail-qt1-x82a.google.com [IPv6:2607:f8b0:4864:20::82a]) by sourceware.org (Postfix) with ESMTPS id BE7493858407 for ; Fri, 17 Dec 2021 19:02:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE7493858407 Received: by mail-qt1-x82a.google.com with SMTP id l8so3630410qtk.6 for ; Fri, 17 Dec 2021 11:02:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iFFZIzyz5Hl7eQTRfUOXUGuTs2kYyLlw+Hd3bkjTmJo=; b=saiOowl+KB9YDXczKsQQT2mGhN9Nz2fVveUC5bE8/MRGOygANKynIZ+VL5TMeoZOek CMSWu2BIEbTiWtNDc/Rm3ghSinJmW3CywMrG3jWYf0fZPsUqIFo3ZmHQYcSQqwIIrss9 HMLoqMOdlJ1UT6Cm19e0SwkEfU1tz5s6j4ciUrnTkN3bwYZk5vl7MCZvqHM8X4MQ1rVm gV3531LuwN+VGf7D+BkQYnSGRDQE328b/mjpmCBwnqRs8KWj5K5QbKoYwW9KE1OaYhFb eSrqmDwEF0uFA92RD4eX/rIFUn33kyXOM9zZjoNv2bwwcqTmvPeeb1jKySriUeld+eqp UFIA== X-Gm-Message-State: AOAM531ZcDS2F9yAFWb6ZYNELAs60fI9j7R9+c5omwex7Usews0yJXkx MB+MlU8g9nf23/mrBqg19MVGFA== X-Google-Smtp-Source: ABdhPJzzdiQi/TlODCygOCZYcP+Ru8q0/S8iHhV5bpCrGFKUorrzwy7PQuD9wM+RJSjh5xVeApmOhQ== X-Received: by 2002:a05:622a:292:: with SMTP id z18mr3695047qtw.205.1639767723316; Fri, 17 Dec 2021 11:02:03 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:103f:7084:332e:7513:f115? ([2804:431:c7ca:103f:7084:332e:7513:f115]) by smtp.gmail.com with ESMTPSA id 2sm5162022qkr.126.2021.12.17.11.02.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Dec 2021 11:02:03 -0800 (PST) Message-ID: <3040760d-a49c-a1c6-5fd9-69b4ac32d9df@linaro.org> Date: Fri, 17 Dec 2021 16:02:00 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v6 09/20] elf: Add _dl_audit_pltexit Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, John Mellor-Crummey , Ben Woodard References: <20211115183734.531155-1-adhemerval.zanella@linaro.org> <20211115183734.531155-10-adhemerval.zanella@linaro.org> <87y24jgm95.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87y24jgm95.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 19:02:05 -0000 On 17/12/2021 14:43, Florian Weimer wrote: > * Adhemerval Zanella: > >> +#if (!ELF_MACHINE_NO_RELA && !defined ELF_MACHINE_PLT_REL) \ >> + || ELF_MACHINE_NO_REL >> +# define PLTREL ElfW(Rela) >> +#else >> +# define PLTREL ElfW(Rel) >> +#endif > > Can you move this definition into some shared header, so that > elf/dl-runtime.c and elf/dl-audit.c can use a single definition? > > I have looked at the actual _dl_audit_pltexit function introduction, and > it looks okay. But I'd review this again as part of a repost, actually > applying the patch. I recall why I haven't done it: it is mainly because it requires the dl-machine.h definition and this header is kinda tricky to include. I will check if we can move to a common header.