From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by sourceware.org (Postfix) with ESMTPS id E6B903858D39 for ; Mon, 3 Apr 2023 18:33:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E6B903858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x22a.google.com with SMTP id q27so21720144oiw.0 for ; Mon, 03 Apr 2023 11:33:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680546830; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cAojtNhR/0IVBG4wnfPu1ICYDsHZB5lOUENZUyb6yqc=; b=LKA7Qvgl4GdqD0Y+qzKmJi4FYR7Wr0/SwV0/bE0trdgkpo1WWQkB4n09IiBIK852eh Qgu/GVA4R5w5WDSiNmIWTgrWrqVnqd0FBHP7+Y1mjIw52s/3PRJV5dygoTW9WOS+GpUr KxfW9L0rNZ4LDdeRdpZ2nOGLRFXjCy5EUHyfasm1ybHIPUvo08eT17Vl2Q/MGgjQFVF6 t8MpOno5Got7YUFpUB+fLS/7gTpwBxMA6q12zn5NTcAQgO3+bjaLoQUW3EU02y59jaPZ CGhet4m1d5kTIrjNQnQ1/Y02I/x1i+fBIyKHD/mlEh+5kXLh1KaTA46np9HhYsbIYv1x 6QLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680546830; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cAojtNhR/0IVBG4wnfPu1ICYDsHZB5lOUENZUyb6yqc=; b=OoX1ZErCMm84WkgHSmPmPJbCQVYbo7E5Pjg79PjQVlPISF7bA19qxZAYjEbo7Mo1y9 WsiQAeHu4XvVJ1eV2yE0+naX4FVSMVSGejW22fq7P9dj2NViUEXU4GPV8aK2m8agw9SS SQbPbekQb2uqm8cvBHu1mpTXTUsm4Qq6HewCSDWRaLp017+LizJhfIblpCRwE3o6C74j q3ipv7flK/sQ1fv5/HHi94dKapuXKJeIt0B9x47RzgfsS8OmuEipPEUOlejQfUvbnBFR gHY8OsFnzjaCsaqks8iKc7tTdlZQhwXfoxVr1b08XKvhKCF02EKMHiQWT7vcS2iS6N1b fl+Q== X-Gm-Message-State: AAQBX9dNFmZLlNWw5esa3xjz22C5z1RwOAX8iUpbWdVAZd6YgiapuZFh 3Q/9mkVDYJpm2JLIEACb6H4dCrwU8eqyH3G8bfzmIQ== X-Google-Smtp-Source: AKy350YKXhtrycHHwGMZ+o/oGKqmrdtMY+p1U39KriCKc2G6oUKh4oNuOi7hz1mwfFpp1Mt9mQe8Xw== X-Received: by 2002:a05:6808:6c6:b0:387:826b:deb3 with SMTP id m6-20020a05680806c600b00387826bdeb3mr137394oih.19.1680546830087; Mon, 03 Apr 2023 11:33:50 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:e5a5:d98f:a7e2:1bb3:d0a7? ([2804:1b3:a7c1:e5a5:d98f:a7e2:1bb3:d0a7]) by smtp.gmail.com with ESMTPSA id h4-20020aca1804000000b003896fc34eddsm4084489oih.52.2023.04.03.11.33.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Apr 2023 11:33:49 -0700 (PDT) Message-ID: <3064c4e8-beb4-126f-e2b4-81b1acbd3b91@linaro.org> Date: Mon, 3 Apr 2023 15:33:46 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 5/5] math: Remove the error handling wrapper from fmod and fmodf Content-Language: en-US To: Wilco Dijkstra , "libc-alpha@sourceware.org" , "H . J . Lu" References: <20230320160118.352206-1-adhemerval.zanella@linaro.org> <20230320160118.352206-6-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 03/04/23 10:43, Wilco Dijkstra wrote: > Hi Adhemerval, > > LGTM - one minor nit about the is_inf functions, are they actually needed? > I'm happy for this to go in either way. > > Reviewed-by: Wilco Dijkstra > > Cheers, > Wilco > > diff --git a/sysdeps/ieee754/flt-32/math_config.h b/sysdeps/ieee754/flt-32/math_config.h > index 829430ea28..f97cd39df1 100644 > --- a/sysdeps/ieee754/flt-32/math_config.h > +++ b/sysdeps/ieee754/flt-32/math_config.h > @@ -125,6 +125,12 @@ is_nan (uint32_t x) >    return (x & EXP_MANT_MASK) > EXPONENT_MASK; >  } >   > +static inline bool > +is_inf (uint32_t x) > +{ > +  return (x & EXP_MANT_MASK) == EXPONENT_MASK; > +} > > Used? It is a left-over from previous version, I will remove it.