From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org, "Timm Bäder" <tbaeder@redhat.com>
Subject: Re: [PATCH] Linux: Forward declaration of struct iovec for process_madvise
Date: Wed, 29 Jun 2022 08:40:47 -0300 [thread overview]
Message-ID: <30EC3624-808E-438D-89E1-A0AC583668F7@linaro.org> (raw)
In-Reply-To: <87iloj3gdo.fsf@oldenburg.str.redhat.com>
> On 29 Jun 2022, at 07:37, Florian Weimer <fweimer@redhat.com> wrote:
>
> This maintains compatibility between <sys/mman.h> and <linux/uio.h>.
> Before that, the addition of process_madvise made those two header
> files incompatible. This has been observed resulting in a build
> failure in LLDB's Process/Linux/NativeRegisterContextLinux_s390x.cpp
> source file.
>
> Fixes commit d19ee3473d68ca0e794f3a8b7677a0983ae1342e
> ("linux: Add process_madvise").
>
> Tested on i686-linux-gnu, x86_64-linux-gnu. Built with
> build-many-glibs.py.
LGTM, thanks.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
>
> ---
> sysdeps/unix/sysv/linux/bits/mman_ext.h | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/sysdeps/unix/sysv/linux/bits/mman_ext.h b/sysdeps/unix/sysv/linux/bits/mman_ext.h
> index 97234a7adf..5612852e64 100644
> --- a/sysdeps/unix/sysv/linux/bits/mman_ext.h
> +++ b/sysdeps/unix/sysv/linux/bits/mman_ext.h
> @@ -21,11 +21,8 @@
> #endif
>
> #ifdef __USE_GNU
> -#include <bits/types/struct_iovec.h>
> -
> -/*
> - */
> -extern __ssize_t process_madvise (int __pid_fd, const struct iovec* __iov,
> +struct iovec;
> +extern __ssize_t process_madvise (int __pid_fd, const struct iovec *__iov,
> size_t __count, int __advice,
> unsigned __flags)
> __THROW;
>
prev parent reply other threads:[~2022-06-29 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 10:37 Florian Weimer
2022-06-29 11:40 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=30EC3624-808E-438D-89E1-A0AC583668F7@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=tbaeder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).