From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id 37ED838582A7 for ; Wed, 29 Jun 2022 11:40:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 37ED838582A7 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-f2a4c51c45so21027775fac.9 for ; Wed, 29 Jun 2022 04:40:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=iT7REOhw38G8FCE25sni7nJPZfDOssbJBynTzjERR2Y=; b=I9aMCeUEPSH7YjVDRjQY4V35zlLqqqNKEYTTj+aMLC7Eqn82UDChW/1AwbY6Ory6Pr LiTE+8bnEIRUYhKeT4iGznkSAVKJwkulXLZfTgcytS1jDwm4xWE4la6j8n8Yth2HloUg nbB6+vGfmRQyKb5hf2lA8Rxt9QX9/p84CoTOO898x5dxEygX+zKVlqH9dV8th3shL52G slYHPknvJjlfSy+vV2PrPbhSVAplSv0rac6fSpRziNt213K3q0RzW6+Lvh/deDPGO4RY TMD8IbYIeTlZOkRMF64e5OzlrrO3yQYUtnz5lHFmE6DATtSt7oPxyk0sF8roZQw8kB2p yVvw== X-Gm-Message-State: AJIora9SHMPUT1m6NfrpzcN/YUBgcoRqQ6Zw3+Pt+GiI663t4BXhzcF1 CJ0BpXwjITzotK1lNJRrTwA4Dw== X-Google-Smtp-Source: AGRyM1s24Jk9BrSMhtD3PAEO4cgK/2WBPFdZvPW6G3PELTuszkIF3J0E/Vec95wPjvZFMf2U4n1Iig== X-Received: by 2002:a05:6870:c995:b0:108:297d:672a with SMTP id hi21-20020a056870c99500b00108297d672amr1574300oab.86.1656502853208; Wed, 29 Jun 2022 04:40:53 -0700 (PDT) Received: from smtpclient.apple ([177.138.183.172]) by smtp.gmail.com with ESMTPSA id o7-20020a056870524700b0010897986b82sm6344142oai.2.2022.06.29.04.40.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Jun 2022 04:40:52 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: [PATCH] Linux: Forward declaration of struct iovec for process_madvise From: Adhemerval Zanella In-Reply-To: <87iloj3gdo.fsf@oldenburg.str.redhat.com> Date: Wed, 29 Jun 2022 08:40:47 -0300 Cc: libc-alpha@sourceware.org, =?utf-8?Q?Timm_B=C3=A4der?= Content-Transfer-Encoding: quoted-printable Message-Id: <30EC3624-808E-438D-89E1-A0AC583668F7@linaro.org> References: <87iloj3gdo.fsf@oldenburg.str.redhat.com> To: Florian Weimer X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2022 11:40:56 -0000 > On 29 Jun 2022, at 07:37, Florian Weimer wrote: >=20 > This maintains compatibility between and . > Before that, the addition of process_madvise made those two header > files incompatible. This has been observed resulting in a build > failure in LLDB's Process/Linux/NativeRegisterContextLinux_s390x.cpp > source file. >=20 > Fixes commit d19ee3473d68ca0e794f3a8b7677a0983ae1342e > ("linux: Add process_madvise"). >=20 > Tested on i686-linux-gnu, x86_64-linux-gnu. Built with > build-many-glibs.py. LGTM, thanks. Reviewed-by: Adhemerval Zanella >=20 > --- > sysdeps/unix/sysv/linux/bits/mman_ext.h | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) >=20 > diff --git a/sysdeps/unix/sysv/linux/bits/mman_ext.h = b/sysdeps/unix/sysv/linux/bits/mman_ext.h > index 97234a7adf..5612852e64 100644 > --- a/sysdeps/unix/sysv/linux/bits/mman_ext.h > +++ b/sysdeps/unix/sysv/linux/bits/mman_ext.h > @@ -21,11 +21,8 @@ > #endif >=20 > #ifdef __USE_GNU > -#include > - > -/* > - */ > -extern __ssize_t process_madvise (int __pid_fd, const struct iovec* = __iov, > +struct iovec; > +extern __ssize_t process_madvise (int __pid_fd, const struct iovec = *__iov, > size_t __count, int __advice, > unsigned __flags) > __THROW; >=20