Re: Questions about failing testcase nptl/test-mutex-printers

[Stefan Liebler <stli@linux.vnet.ibm.com>]

On 04/18/2018 04:40 PM, Tulio Magno Quites Machado Filho wrote:
> Stefan Liebler <stli@linux.vnet.ibm.com> writes:
> 
>> As I don't have access to other lock-elision enabled machines,
>> can somebody test this on power / intel?
> 
> Tested on powerpc.  Same behavior.
> 
>> If I step manually to the tbegin-instruction (which starts the
>> transaction on s390x) and step over it, then gdb steps over the whole
>> transaction and we are just after the tend-instruction.
> 
> That behavior also happens on powerpc with all kinds of transactions.
> But it's the GDB behavior with transactions on powerpc.
> I don't know the details on s390x.
> 
>> Does it make sense to disable lock-elision for the pretty-printer-tests?
>> E.g. with the following patch:
>> diff --git a/scripts/test_printers_common.py
>> b/scripts/test_printers_common.py
>> index 73ca525556..d74a8b4d4b 100644
>> --- a/scripts/test_printers_common.py
>> +++ b/scripts/test_printers_common.py
>> @@ -171,6 +171,9 @@ def init_test(test_bin, printer_files, printer_names):
>>        # Finally, load the test binary.
>>        test('file {0}'.format(test_bin))
>>
>> +    # Disable lock elision.
>> +    test('set environment GLIBC_TUNABLES glibc.elision.enable=0')
>> +
>>    def go_to_main():
>>        """Executes a gdb 'start' command, which takes us to main."""
> 
> LGTM.
> 

Thanks.
Committed:
https://sourceware.org/git/?p=glibc.git;a=commit;h=0085be1415a38b40a5a1a12e49368498f1687380