From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gnu.wildebeest.org (gnu.wildebeest.org [45.83.234.184]) by sourceware.org (Postfix) with ESMTPS id 41B703898C7A for ; Mon, 10 Jan 2022 12:13:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41B703898C7A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=klomp.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=klomp.org Received: from tarox.wildebeest.org (83-87-18-245.cable.dynamic.v4.ziggo.nl [83.87.18.245]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8ACDD30008AE; Mon, 10 Jan 2022 13:13:37 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id E3DBC4000944; Mon, 10 Jan 2022 13:13:36 +0100 (CET) Message-ID: <30f880311083b4bfc59f6a1334a964bdcc54fa57.camel@klomp.org> Subject: Re: [PATCH] Add valgrind smoke test From: Mark Wielaard To: Alexandra =?ISO-8859-1?Q?H=E1jkov=E1?= , libc-alpha@sourceware.org Cc: Alexandra =?ISO-8859-1?Q?H=E1jkov=E1?= Date: Mon, 10 Jan 2022 13:13:36 +0100 In-Reply-To: <20211220113742.1951911-1-ahajkova@redhat.com> References: <20211206144043.858697-1-ahajkova@redhat.com> <20211220113742.1951911-1-ahajkova@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Evolution 3.28.5 (3.28.5-10.el7) Mime-Version: 1.0 X-Spam-Status: No, score=-3.9 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jan 2022 12:13:42 -0000 HI, On Mon, 2021-12-20 at 12:37 +0100, Alexandra H=C3=A1jkov=C3=A1 wrote: > Check if whether valgrind is available in the test environment. > If not, skip the test. Run smoke tests with valgrind to verify > dynamic loader. > First, check if algrind works with the system ld.so in the test > environment. Then run the actual test inside the test environment, > using the just build ld.so and new libraries. > [...] > +# Test valgrind works with the system ld.so in the test environment > +/bin/sh -c \ > + "${test_wrapper_env} ${run_program_env} \ > + valgrind -q --error-exitcode=3D1 \ > + ${system_rtld} /bin/echo ${system_rtld}" || exit 77 So now you use /bin/echo instead of the newly build testcase. Looks ok. The main thing is that it tests running the system ld.so under valgrind works. If it does, then the new ld.so should too. I think that is correct given DJ's feedback. Although I admit am a little surprised to be honest. I didn't think the test used any new symbol (versions), so would also work against the system libc. But since it was build against the fresh glibc, it does make sense it could pull in newer symbol versions than are available on the system. This version looks good to me to get integrated. Thanks, Mark