From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from quail.birch.relay.mailchannels.net (quail.birch.relay.mailchannels.net [23.83.209.151]) by sourceware.org (Postfix) with ESMTPS id E99E03886C77 for ; Wed, 30 Jun 2021 09:33:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E99E03886C77 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 074534000E8; Wed, 30 Jun 2021 09:33:17 +0000 (UTC) Received: from pdx1-sub0-mail-a26.g.dreamhost.com (100-96-16-83.trex-nlb.outbound.svc.cluster.local [100.96.16.83]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 877B4402F09; Wed, 30 Jun 2021 09:33:16 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from pdx1-sub0-mail-a26.g.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384) by 100.96.16.83 (trex/6.3.3); Wed, 30 Jun 2021 09:33:16 +0000 X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Fumbling-Attack: 2e9dcfc3539ac508_1625045596830_2345406282 X-MC-Loop-Signature: 1625045596830:4271247113 X-MC-Ingress-Time: 1625045596829 Received: from pdx1-sub0-mail-a26.g.dreamhost.com (localhost [127.0.0.1]) by pdx1-sub0-mail-a26.g.dreamhost.com (Postfix) with ESMTP id 44EC180A8C; Wed, 30 Jun 2021 09:33:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=fPn+IS busOknJFgti+AYvuQNARk=; b=TIPJcsh+ZiAqpzWqGs3SfMr7GlfUrYbx3rT+g0 YJ8Q/ILqzFSCY2AtotwYv4DhlKJYqqYuUP9M6qXRr8FF+bqCTP1bfedL8UysUq5N U6/mdSjBvKFS+MgM/LMSfTMX+Gwf84KS3l5F04U7329i4BuO40+xhsHI9yTiHvxl LbGZw= Received: from [192.168.1.136] (unknown [1.186.101.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a26.g.dreamhost.com (Postfix) with ESMTPSA id 7EC877EFD7; Wed, 30 Jun 2021 09:33:11 +0000 (UTC) Subject: Re: [PATCH] AArch64: Add hp-timing.h To: Florian Weimer , Szabolcs Nagy via Libc-alpha Cc: Szabolcs Nagy , Siddhesh Poyarekar , Wilco Dijkstra References: <20210630084643.GE14854@arm.com> <878s2rk9z2.fsf@oldenburg.str.redhat.com> X-DH-BACKEND: pdx1-sub0-mail-a26 From: Siddhesh Poyarekar Message-ID: <3117c71b-4354-219e-bff8-af3858da48c3@gotplt.org> Date: Wed, 30 Jun 2021 15:03:05 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <878s2rk9z2.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3030.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2021 09:33:20 -0000 On 6/30/21 2:25 PM, Florian Weimer via Libc-alpha wrote: > * Szabolcs Nagy via Libc-alpha: > >> The 06/28/2021 11:11, Wilco Dijkstra wrote: >>> Add hp-timing.h using the cntcvt_el0 counter. Return timing in nanoseconds >>> so it is fully compatible with generic hp-timing. Don't set HP_TIMING_INLINE >>> in the dynamic linker since very old kernels may not handle cntcvt correctly. >> >> can you please add a comment here that this >> is only used in internal benchmarks and not >> in installed glibc binaries. with that it's >> ok to commit. > > This commit would not be entirely accurate. We install and ship the > benchtests, so they need to use a stable ISA (and kernel ABI). That doesn't seem like a reasonable limitation for benchtests. > If the benchtests are like the testsuite and are not intended to be > installed and distributed, we probably need to make downstream changes. There's value in having the benchtest binaries in the distribution too, so maybe we need to figure out a way to do both, i.e. not be bound by ABI restrictions and at the same time, be deployable to do performance comparison. Siddhesh