From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH] nscd: Eliminate compilation time dependency in the build output
Date: Thu, 05 Oct 2017 16:14:00 -0000 [thread overview]
Message-ID: <312692e2-c1a4-06df-86f8-d84d0c5fe309@redhat.com> (raw)
In-Reply-To: <20171005144957.6383142022590@oldenburg.str.redhat.com>
On 10/05/2017 07:49 AM, Florian Weimer wrote:
> 2017-10-05 Florian Weimer <fweimer@redhat.com>
>
> nscd: Eliminate compilation time dependency in the build output.
> * nscd/nscd_stat.c (STATDATA_VERSION)
> (STATDATA_VERSION_SELINUX_FLAG, STATDATA_VERSION_FLAGS)
> (STATDATA_VERSION_FULL): New macro definitions.
> (compilation): Remove.
> (struct statdata): Adjust version member.
> (send_stats): Set version from STATDATA_VERSION_FULL.
> (receive_print_stats): Verify version against STATDATA_VERSION_FULL.
Looks good to me.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
--
Cheers,
Carlos.
prev parent reply other threads:[~2017-10-05 16:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 14:50 Florian Weimer
2017-10-05 15:12 ` Zack Weinberg
2017-10-05 16:14 ` Carlos O'Donell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=312692e2-c1a4-06df-86f8-d84d0c5fe309@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).