From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ua1-x934.google.com (mail-ua1-x934.google.com [IPv6:2607:f8b0:4864:20::934]) by sourceware.org (Postfix) with ESMTPS id 1C4783858D39 for ; Thu, 29 Sep 2022 13:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1C4783858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ua1-x934.google.com with SMTP id y20so537138uao.8 for ; Thu, 29 Sep 2022 06:51:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=d/YZrlnveeEqiRowdS3MDWXVSmcTTKCGTKByTgJM9OY=; b=wEXuvBUse/kqgugcZMZe3ucnHTQFtVmSUJcqwKS10mVfaSw1LJjn9RvFB8E0GH3yJz 4xhoaE3HaaF7Jus6jxkr9wrL+9ePVc4rDz6/CbQN6fEtXwqFN7X0gOMxbcv68TDCMKBS DI4LGPOrC+nTjextVrEbtFMO4jVc/ps8Jz8UzQWG8d+ssrTbNkzVkURWRHbd6ecJOAaq EFqjLlCc2dgHorCfu9Fccv+vQ95wcIbtk3HMhEQL8X+7UkjMiwix0eTBOFePB5o7/LM5 vHmSs857jm3beHv51T4x32Tca7z72yV2KhQ8+52uOTmLEiaE9dNpzsMM6BZ/T9kR7yJP rKlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=d/YZrlnveeEqiRowdS3MDWXVSmcTTKCGTKByTgJM9OY=; b=4SSRcCEOiCyIWR7jRtCpozlD9Id89gzoBGDrsBOcj4vrzSQlzlcxiE1dbZJwj9AodP Z/XvLSErRBzNLJSIiyrPRdaphtbjqHFG+4dUXUQwOdaKmVehJTaReevwAfVbI/9w7kCl zg+/izpmaC7ozfZazi/44U0+ayNmZ2kzr2Jo56u9U82jalpp5FspiEIhn92ufSQN0Hxg tyM+U6ve2p/8xW/Hkam1gScxXvL4wpqFs1uPzDK00G2Dt2puoEpSUppeaEiMk1V/QVbg C8fx1R3J1BZBki9lPCWPxgpjScKcSLA5y4JllBmmjKIpKgkvNEiwwCBrDBRfDVFXaQY4 QOCQ== X-Gm-Message-State: ACrzQf2hg1/0WV73C6ufO9b1Inbt9JWOSD/EOZ+LlhN5T9+z31vWajox Ubwbnizp+FvT4DpH89JvcF8L8agDH5IX8FVF X-Google-Smtp-Source: AMsMyM7PDeem1qA+46zWBL9g+A2IseiQ91VN70CXvtJS2R7P/gKPJQwlh4hizPH8ckcC5kJ05v7L5w== X-Received: by 2002:ab0:5992:0:b0:3be:fbae:c964 with SMTP id g18-20020ab05992000000b003befbaec964mr1837656uad.15.1664459512068; Thu, 29 Sep 2022 06:51:52 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:3736:1cf0:b6ef:db77:c498? ([2804:1b3:a7c2:3736:1cf0:b6ef:db77:c498]) by smtp.gmail.com with ESMTPSA id w85-20020a1f9458000000b003a8721c1159sm1663968vkd.38.2022.09.29.06.51.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 06:51:51 -0700 (PDT) Message-ID: <313bf716-fe53-c3cb-f30b-26c38e6341b2@linaro.org> Date: Thu, 29 Sep 2022 10:51:49 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2] malloc: Fix clobbered errno when getrandom failed [BZ #29624] Content-Language: en-US To: Florian Weimer Cc: Yu Chien Peter Lin , libc-alpha@sourceware.org, ycliang@andestech.com, dylan@andestech.com, alankao@andestech.com References: <20220929111323.12670-1-peterlin@andestech.com> <875yh671eq.fsf@mid.deneb.enyo.de> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <875yh671eq.fsf@mid.deneb.enyo.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-14.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 29/09/22 10:31, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> diff --git a/sysdeps/unix/sysv/linux/not-cancel.h b/sysdeps/unix/sysv/linux/not-cancel.h >> index a263d294b1..00ab75a405 100644 >> --- a/sysdeps/unix/sysv/linux/not-cancel.h >> +++ b/sysdeps/unix/sysv/linux/not-cancel.h >> @@ -71,7 +71,7 @@ __writev_nocancel_nostatus (int fd, const struct iovec *iov, int iovcnt) >> static inline int >> __getrandom_nocancel (void *buf, size_t buflen, unsigned int flags) >> { >> - return INLINE_SYSCALL_CALL (getrandom, buf, buflen, flags); >> + return INTERNAL_SYSCALL_CALL (getrandom, buf, buflen, flags); >> } >> >> static inline int > > Doesn't this need a matching change to sysdeps/mach/hurd/not-cancel.h? Yeah, it will to make __arc4random_buf use the /dev/random fallback.