From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 18F713857C5E for ; Fri, 21 Aug 2020 09:30:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 18F713857C5E Received: from pps.filterd (m0098404.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 07L931WU141992 for ; Fri, 21 Aug 2020 05:30:43 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 332b8ags33-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 21 Aug 2020 05:30:43 -0400 Received: from m0098404.ppops.net (m0098404.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 07L93nni147168 for ; Fri, 21 Aug 2020 05:30:41 -0400 Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com with ESMTP id 332b8ags1r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 05:30:41 -0400 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 07L9C5BZ009789; Fri, 21 Aug 2020 09:30:39 GMT Received: from b06avi18878370.portsmouth.uk.ibm.com (b06avi18878370.portsmouth.uk.ibm.com [9.149.26.194]) by ppma06ams.nl.ibm.com with ESMTP id 330tbvtvu4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 21 Aug 2020 09:30:39 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06avi18878370.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 07L9Uanh58196468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 21 Aug 2020 09:30:36 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8245252063; Fri, 21 Aug 2020 09:30:36 +0000 (GMT) Received: from oc4452167425.ibm.com (unknown [9.145.157.249]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 5D5A252059; Fri, 21 Aug 2020 09:30:36 +0000 (GMT) Subject: Re: [PATCH] S390: Sync HWCAP names with kernel by adding aliases [BZ #25971] To: "Carlos O'Donell" , libc-alpha@sourceware.org References: <20200812142831.3694409-1-stli@linux.ibm.com> From: Stefan Liebler Message-ID: <31409397-6a12-cedc-1500-b77d4c282896@linux.ibm.com> Date: Fri, 21 Aug 2020 11:30:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-21_06:2020-08-21, 2020-08-21 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 suspectscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 lowpriorityscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008210084 X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Aug 2020 09:30:46 -0000 On 8/20/20 11:49 PM, Carlos O'Donell wrote: > On 8/12/20 10:28 AM, Stefan Liebler via Libc-alpha wrote: >> Unfortunately some HWCAP names like HWCAP_S390_VX differs between >> kernel (see /arch/s390/include/asm/elf.h) and glibc. >> >> Therefore, those HWCAP names from kernel are now introduced as alias >> to the existing ones in glibc. >> --- >> sysdeps/s390/dl-procinfo.h | 3 +++ >> sysdeps/unix/sysv/linux/s390/bits/hwcap.h | 3 +++ >> 2 files changed, 6 insertions(+) >> >> diff --git a/sysdeps/s390/dl-procinfo.h b/sysdeps/s390/dl-procinfo.h >> index 0db4bc39c7..08eee109f7 100644 >> --- a/sysdeps/s390/dl-procinfo.h >> +++ b/sysdeps/s390/dl-procinfo.h >> @@ -51,8 +51,11 @@ enum >> HWCAP_S390_HIGH_GPRS = 1 << 9, >> HWCAP_S390_TE = 1 << 10, >> HWCAP_S390_VX = 1 << 11, >> + HWCAP_S390_VXRS = HWCAP_S390_VX, >> HWCAP_S390_VXD = 1 << 12, >> + HWCAP_S390_VXRS_BCD = HWCAP_S390_VXD, >> HWCAP_S390_VXE = 1 << 13, >> + HWCAP_S390_VXRS_EXT = HWCAP_S390_VXE, >> HWCAP_S390_GS = 1 << 14, >> HWCAP_S390_VXRS_EXT2 = 1 << 15, >> HWCAP_S390_VXRS_PDE = 1 << 16, >> diff --git a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h >> index 6adbec018b..f2998ff131 100644 >> --- a/sysdeps/unix/sysv/linux/s390/bits/hwcap.h >> +++ b/sysdeps/unix/sysv/linux/s390/bits/hwcap.h >> @@ -36,8 +36,11 @@ >> #define HWCAP_S390_HIGH_GPRS 512 >> #define HWCAP_S390_TE 1024 >> #define HWCAP_S390_VX 2048 >> +#define HWCAP_S390_VXRS HWCAP_S390_VX >> #define HWCAP_S390_VXD 4096 >> +#define HWCAP_S390_VXRS_BCD HWCAP_S390_VXD >> #define HWCAP_S390_VXE 8192 >> +#define HWCAP_S390_VXRS_EXT HWCAP_S390_VXE >> #define HWCAP_S390_GS 16384 >> #define HWCAP_S390_VXRS_EXT2 32768 >> #define HWCAP_S390_VXRS_PDE 65536 >> > > As the machine maintainer you should assume consensus and just commit this. > > I assume you know what you're doing synchronizing and matching these names. > Sure. Nevertheless feedback is always welcome and I can also wait a bit before commiting it. Now I've committed the patch and resolved the bugzilla. Thanks. Stefan