public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Daniel Cederman <cederman@gaisler.com>
To: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>,
	libc-alpha@sourceware.org
Cc: daniel@gaisler.com, andreas@gaisler.com
Subject: Re: [PATCH] sparc: Treat the version field in the FPU control word as reserved
Date: Thu, 15 Feb 2024 10:31:25 +0100	[thread overview]
Message-ID: <318b9a72-e84c-41a5-a0ac-684bfcb02007@gaisler.com> (raw)
In-Reply-To: <74d588e4-69cc-4f66-924a-029ae257776c@linaro.org>

Hello Adhemerval,

Can you apply this to master if you are ok with the patch?

/Daniel

On 2024-01-12 18:42, Adhemerval Zanella Netto wrote:
> 
> 
> On 12/01/24 06:26, Daniel Cederman wrote:
>> The FSR version field is read-only and might be non-zero.
>>
>> This allows math/test-fpucw* to correctly pass when the version is
>> non-zero.
>>
>> Signed-off-by: Daniel Cederman <cederman@gaisler.com>
> 
> It looks reasonable to mask off the version _FPU_RESERVED.  It also
> means that it would be change by __setfpucw, although afaik the ISA
> guarantee that it can not be changed anyway.
> 
> Reviewed-by: Adhemerval Zanella  <adhemerval.zanella@linaro.org>
> 
>> ---
>>   sysdeps/sparc/fpu/fpu_control.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/sysdeps/sparc/fpu/fpu_control.h b/sysdeps/sparc/fpu/fpu_control.h
>> index 9313743f86..36a2bf5d07 100644
>> --- a/sysdeps/sparc/fpu/fpu_control.h
>> +++ b/sysdeps/sparc/fpu/fpu_control.h
>> @@ -42,7 +42,7 @@
>>   #define _FPU_RC_ZERO    0x40000000
>>   #define _FPU_RC_NEAREST 0x0        /* RECOMMENDED */
>>   
>> -#define _FPU_RESERVED   0x30300000  /* Reserved bits in cw */
>> +#define _FPU_RESERVED   0x303e0000  /* Reserved bits in cw */
>>   
>>   
>>   /* Now two recommended cw */

  reply	other threads:[~2024-02-15  9:31 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12  9:26 [PATCH] sparc: Do not test preservation of NaN payloads for LEON Daniel Cederman
2024-01-12  9:26 ` [PATCH] sparc: Prevent stfsr from directly following floating-point instruction Daniel Cederman
2024-01-12 14:38   ` Adhemerval Zanella Netto
2024-01-15  9:37     ` Daniel Cederman
2024-01-12  9:26 ` [PATCH] sparc: Force calculation that raises exception Daniel Cederman
2024-01-12 16:45   ` Adhemerval Zanella Netto
2024-01-15  9:41     ` Daniel Cederman
2024-01-15 11:47       ` Adhemerval Zanella Netto
2024-01-12  9:26 ` [PATCH] sparc: Treat the version field in the FPU control word as reserved Daniel Cederman
2024-01-12 17:42   ` Adhemerval Zanella Netto
2024-02-15  9:31     ` Daniel Cederman [this message]
2024-02-19 14:55       ` Adhemerval Zanella Netto
2024-01-12  9:26 ` [PATCH] sparc: Fix llrint and llround missing exceptions on SPARC32 Daniel Cederman
2024-01-12 18:05   ` Adhemerval Zanella Netto
2024-01-15 14:38     ` Daniel Cederman
2024-01-15 17:52       ` Adhemerval Zanella Netto
2024-01-12  9:26 ` [PATCH] sparc: Remove unwind information from signal return stub functions Daniel Cederman
2024-01-15 13:41   ` Adhemerval Zanella Netto
2024-01-15 14:22     ` Daniel Cederman
2024-01-15 16:57       ` Adhemerval Zanella Netto
2024-01-16 15:37 ` [PATCH] sparc: Do not test preservation of NaN payloads for LEON Adhemerval Zanella Netto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=318b9a72-e84c-41a5-a0ac-684bfcb02007@gaisler.com \
    --to=cederman@gaisler.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=andreas@gaisler.com \
    --cc=daniel@gaisler.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).