From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 867453858D1E for ; Mon, 6 May 2024 12:55:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 867453858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 867453858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715000150; cv=none; b=upUbY8xbJiInsrJhrRO0X+hp/JdV16bUUOyeIvDABI68KO7OamBJNk32SPwsVzamLd9gu54k09hAy9Q3M0NSVt3GmdFagJ4GqLyVjR+/DcNarg+EXD6LPsYAh3NHQXMjgnMogAjd4gAFV7RT3XSS3Pb5jfN/BXQP5Wm4W3N8MxM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715000150; c=relaxed/simple; bh=xjyYXCrhC5jJm/hs8k4Ub7YPriXlZWXFMM2VqU5YbG4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=xroFGkElFlF2e133zZ+Yb0izSLSOZ4NssuZpO7dRXsuiECicNAk//r9Y8pVgmIZEdfz/0g+w/qfh3QAERqRElo5pG/6OhI+V6sjO8pyCyKPKf90c46tgUIL75uFAEBYI2PZ5x4uF5o+vgSJ/eVBuw+Z2CNbm8uBF2LluXE/6n+s= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353724.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 446Ce4dY008155; Mon, 6 May 2024 12:55:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=fupEYp0xDoczmiJPvOPnvQe9GmMom0ZsRxmG1/nIxZM=; b=oicBYpBpMB+uUEge3xeX8o7cbdYWopE226wg68Lg+pKnT+oEBwHZWm0FFVeytMy5ecsw LnkkB9yyz9JzPtgAdVxgAnRiAT/T7Zn+l4tWEnsjriZw8SWrPq3dytNh2LiTXeqbiBDl 0glZKmV6loLDpXUqtphiuhbSBokNMG6YCOCBwLoe521bykJ8q82s34XU7TnHjIinXhsv Y29pE/oG4Mx7P7302KGw/Pn3LC2a4BvYAerUrTwPtKknDoH1zxc4vKP8hIcm5XCWuXb0 T2q/tjQnELFVQqh7eZQewO+8MBqkrBaPrFqlggFuLn8sV/5QrWwMfAdoj2cPxkF21Tzt Mw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xxy1ug2x1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 12:55:47 +0000 Received: from m0353724.ppops.net (m0353724.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 446CtkJx001703; Mon, 6 May 2024 12:55:47 GMT Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3xxy1ug2wy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 12:55:46 +0000 Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 446BkUds030902; Mon, 6 May 2024 12:55:46 GMT Received: from smtprelay02.dal12v.mail.ibm.com ([172.16.1.4]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 3xwybtr6rx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 May 2024 12:55:46 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay02.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 446CthFK46596616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 May 2024 12:55:45 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5E3BE5805D; Mon, 6 May 2024 12:55:43 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E929D58056; Mon, 6 May 2024 12:55:42 +0000 (GMT) Received: from [9.61.161.194] (unknown [9.61.161.194]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 May 2024 12:55:42 +0000 (GMT) Message-ID: <31ab9d67-8027-4bdb-8ca3-f34b0d8a8f8d@linux.ibm.com> Date: Mon, 6 May 2024 07:55:42 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [V3] powerpc: Optimized strncmp for power10 To: Florian Weimer Cc: Amrita H S , libc-alpha@sourceware.org, Paul E Murphy , Adhemerval Zanella References: <20240429095847.3541150-1-amritahs@linux.vnet.ibm.com> <87zft3a2og.fsf@oldenburg.str.redhat.com> Content-Language: en-US From: Peter Bergner In-Reply-To: <87zft3a2og.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: _dGr71gvP09P__Mxtnn9DZzVi9ZIoBpk X-Proofpoint-GUID: FbSE-4MR3I3r2C1TXJcjhVU5L-JpFP-2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1011,Hydra:6.0.650,FMLib:17.11.176.26 definitions=2024-05-06_08,2024-05-06_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 mlxlogscore=956 malwarescore=0 suspectscore=0 impostorscore=0 clxscore=1015 adultscore=0 mlxscore=0 spamscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2404010000 definitions=main-2405060089 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/6/24 1:13 AM, Florian Weimer wrote: > * Peter Bergner: > >> This code looks like it assumes the kernel is using a 4k page size. >> All distros that I know of and the default kernel config for ppc64 >> and ppc64le kernels is to use a 64K HW page size. Is there a reason >> we're not checking for a 64k cache boundary here? > > The ABI says the minimum page size is 4K, right? The HW supports a 4K page size, but none of the major distros use that, they all use 64K pages. That said, one of our kernel developers said that are a couple of minor distros building with 4K pages, so I guess we should go with that until... > I suppose we could add a page size check on startup and make glibc > requirements configure and build time. Yes, this sounds like a good future project, but no need to hold this patch up for that. Peter