From: "Michael Kerrisk (man-pages)" <mtk.manpages@gmail.com>
To: Yubin Ruan <ablacktshirt@gmail.com>
Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org,
libc-alpha@sourceware.org
Subject: Re: [PATCTH 0/2] pthread_mutexattr_setrobust() and pthread_mutex_consistent()
Date: Fri, 15 Sep 2017 07:53:00 -0000 [thread overview]
Message-ID: <31afda7b-cc49-7c8f-c6d4-79b4d4daab1c@gmail.com> (raw)
In-Reply-To: <20170915094414.GA18043@HP.internal.baidu.com>
On 09/15/2017 11:45 AM, Yubin Ruan wrote:
> On Wed, Sep 13, 2017 at 05:00:11PM +0200, Michael Kerrisk (man-opages) wrote:
>> Hi Yubin
>>
>>> Hi Michael,
>>>
>>> Sorry that it took so long.
>>>
>>> Following is the renew patch. I have corrected several formatting issues (i.e.,
>>> \n , - , but I can't find anything wrong with ' ) and some typos. The only
>>> issue I cannot solve is that the new `pthread_mutex_consistent(3)` page is too
>>> short that it shows at the very bottom... please help with this.
>>>
>>> Also, please find attached three verification snippets.
>>
>> I've done some heavy editing, and added quite a few pieces to these pages,
>> and pushed the results to Git. Go take a look and let me know
>> of anything you think needs fixing. Thanks for these pages!
>
> Good job. No objection, except a minor change and some code formatting change.
> See the diff below.
Thanks, Yubin. Applied.
Cheers,
Michael
> diff --git a/man3/pthread_mutexattr_setrobust.3 b/man3/pthread_mutexattr_setrobust.3
> index e9e8e76..66b4bed 100644
> --- a/man3/pthread_mutexattr_setrobust.3
> +++ b/man3/pthread_mutexattr_setrobust.3
> @@ -86,7 +86,7 @@ on the mutex will block indefinitely.
> .TP
> .B PTHREAD_MUTEX_ROBUST
> If a mutex is initialized with the
> -.BR PTHREAD_MUTEX_ROBUST ,
> +.BR PTHREAD_MUTEX_ROBUST
> attribute and its owner dies without unlocking it,
> any future attempts to call
> .BR pthread_mutex_lock (3)
> @@ -255,22 +255,21 @@ main(int argc, char *argv[])
> s = pthread_mutex_lock(&mtx);
> if (s == EOWNERDEAD) {
> printf("[main thread] pthread_mutex_lock() returned EOWNERDEAD\\n");
> - printf("[main thread] Now make the mutex consistent\\n");
> + printf("[main thread] Now make the mutex consistent\\n");
> s = pthread_mutex_consistent(&mtx);
> if (s != 0)
> - handle_error_en(s, "pthread_mutex_consistent");
> - printf("[main thread] Mutex is now consistent; unlocking\\n");
> + handle_error_en(s, "pthread_mutex_consistent");
> + printf("[main thread] Mutex is now consistent; unlocking\\n");
> s = pthread_mutex_unlock(&mtx);
> if (s != 0)
> - handle_error_en(s, "pthread_mutex_unlock");
> -
> + handle_error_en(s, "pthread_mutex_unlock");
> exit(EXIT_SUCCESS);
> } else if (s == 0) {
> - printf("[main thread] pthread_mutex_lock() unexpectedly succeeded\\n");
> - exit(EXIT_FAILURE);
> + printf("[main thread] pthread_mutex_lock() unexpectedly succeeded\\n");
> + exit(EXIT_FAILURE);
> } else {
> - printf("[main thread] pthread_mutex_lock() unexpectedly failed\\n");
> - handle_error_en(s, "pthread_mutex_lock");
> + printf("[main thread] pthread_mutex_lock() unexpectedly failed\\n");
> + handle_error_en(s, "pthread_mutex_lock");
> }
> }
>
>
--
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
prev parent reply other threads:[~2017-09-15 7:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-20 9:43 Yubin Ruan
2017-08-21 2:25 ` Yubin Ruan
2017-08-21 2:31 ` Yubin Ruan
2017-08-22 0:33 ` Michael Kerrisk (man-pages)
2017-08-22 2:19 ` Yubin Ruan
2017-08-26 14:10 ` Yubin Ruan
2017-09-11 1:50 ` Yubin Ruan
2017-09-11 20:35 ` Michael Kerrisk (man-pages)
2017-09-12 12:41 ` Michael Kerrisk (man-pages)
2017-09-13 1:39 ` Yubin Ruan
2017-09-13 4:09 ` Yubin Ruan
2017-09-13 12:28 ` Michael Kerrisk (man-pages)
2017-09-15 1:34 ` Yubin Ruan
2017-09-13 15:00 ` Michael Kerrisk (man-opages)
2017-09-15 2:49 ` Yubin Ruan
2017-09-15 7:53 ` Michael Kerrisk (man-pages) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31afda7b-cc49-7c8f-c6d4-79b4d4daab1c@gmail.com \
--to=mtk.manpages@gmail.com \
--cc=ablacktshirt@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-man@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).