From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x844.google.com (mail-qt1-x844.google.com [IPv6:2607:f8b0:4864:20::844]) by sourceware.org (Postfix) with ESMTPS id 3EEC5386F021 for ; Mon, 20 Apr 2020 20:18:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3EEC5386F021 Received: by mail-qt1-x844.google.com with SMTP id s30so9774191qth.2 for ; Mon, 20 Apr 2020 13:18:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0hng715J8PB5JYkBGnvPgZCorgz+/byRiFHEYKx7GFI=; b=IR5IBI1yZZwzDwxP7CmZqkD6/NfcEiqdmgfOlI0xXFU/PJaBGBI6xF6XQtUwdVstn0 qSUGdM46TDSvBNQ6bMJZzUOfGg/dbb3GRFGhhL2nddffpcQsO72BdLzF92qnmgbfQXWT QWXmQTKQ0HT3rr32U0aYeWReNJxufoGNcMo/ryBHcgmLEBY6NVsVcHyq6udMVccG1ZjG sCfocCDpCF3jHo4cHlaRz59WvNCylvz4EY7MIYdVQM0U5K/io6i8dFG9dvmp6e4gNOvL P5Wab+27sbywpFvtF4Od2Gbxq1XTy0LiNR20SO835+tcIb1Z9w4WnEY4brG7iGDc+CYj rKiw== X-Gm-Message-State: AGi0PuZNabXH+e7r/YaOT/KQZ40zs0XQSe1VdiDEOrN3CbUp7yExrd+W zXfqRzKhkWu7dYapwrSQtphDwm61aGgxBg== X-Google-Smtp-Source: APiQypJ2YGNd6sjkufjRTQJgj1GFOcIADrdw5YGVeG47s/ZlUtRlor8iFVOgx1h8gCQ00FB1/cBqXA== X-Received: by 2002:ac8:48d0:: with SMTP id l16mr15006717qtr.120.1587413908413; Mon, 20 Apr 2020 13:18:28 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id o201sm428903qke.31.2020.04.20.13.18.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Apr 2020 13:18:27 -0700 (PDT) Subject: Re: [PATCH v5 2/3] semctl: Remove the sem-pad.h file To: Alistair Francis Cc: GNU C Library References: <20200401165308.1913271-1-alistair.francis@wdc.com> <20200401165308.1913271-3-alistair.francis@wdc.com> From: Adhemerval Zanella Autocrypt: addr=adhemerval.zanella@linaro.org; prefer-encrypt=mutual; keydata= xsFNBFcVGkoBEADiQU2x/cBBmAVf5C2d1xgz6zCnlCefbqaflUBw4hB/bEME40QsrVzWZ5Nq 8kxkEczZzAOKkkvv4pRVLlLn/zDtFXhlcvQRJ3yFMGqzBjofucOrmdYkOGo0uCaoJKPT186L NWp53SACXguFJpnw4ODI64ziInzXQs/rUJqrFoVIlrPDmNv/LUv1OVPKz20ETjgfpg8MNwG6 iMizMefCl+RbtXbIEZ3TE/IaDT/jcOirjv96lBKrc/pAL0h/O71Kwbbp43fimW80GhjiaN2y WGByepnkAVP7FyNarhdDpJhoDmUk9yfwNuIuESaCQtfd3vgKKuo6grcKZ8bHy7IXX1XJj2X/ BgRVhVgMHAnDPFIkXtP+SiarkUaLjGzCz7XkUn4XAGDskBNfbizFqYUQCaL2FdbW3DeZqNIa nSzKAZK7Dm9+0VVSRZXP89w71Y7JUV56xL/PlOE+YKKFdEw+gQjQi0e+DZILAtFjJLoCrkEX w4LluMhYX/X8XP6/C3xW0yOZhvHYyn72sV4yJ1uyc/qz3OY32CRy+bwPzAMAkhdwcORA3JPb kPTlimhQqVgvca8m+MQ/JFZ6D+K7QPyvEv7bQ7M+IzFmTkOCwCJ3xqOD6GjX3aphk8Sr0dq3 4Awlf5xFDAG8dn8Uuutb7naGBd/fEv6t8dfkNyzj6yvc4jpVxwARAQABzUlBZGhlbWVydmFs IFphbmVsbGEgTmV0dG8gKExpbmFybyBWUE4gS2V5KSA8YWRoZW1lcnZhbC56YW5lbGxhQGxp bmFyby5vcmc+wsF3BBMBCAAhBQJXFRpKAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKqx7BSnlIjv0e8P/1YOYoNkvJ+AJcNUaM5a2SA9oAKjSJ/M/EN4Id5Ow41ZJS4lUA0apSXW NjQg3VeVc2RiHab2LIB4MxdJhaWTuzfLkYnBeoy4u6njYcaoSwf3g9dSsvsl3mhtuzm6aXFH /Qsauav77enJh99tI4T+58rp0EuLhDsQbnBic/ukYNv7sQV8dy9KxA54yLnYUFqH6pfH8Lly sTVAMyi5Fg5O5/hVV+Z0Kpr+ZocC1YFJkTsNLAW5EIYSP9ftniqaVsim7MNmodv/zqK0IyDB GLLH1kjhvb5+6ySGlWbMTomt/or/uvMgulz0bRS+LUyOmlfXDdT+t38VPKBBVwFMarNuREU2 69M3a3jdTfScboDd2ck1u7l+QbaGoHZQ8ZNUrzgObltjohiIsazqkgYDQzXIMrD9H19E+8fw kCNUlXxjEgH/Kg8DlpoYJXSJCX0fjMWfXywL6ZXc2xyG/hbl5hvsLNmqDpLpc1CfKcA0BkK+ k8R57fr91mTCppSwwKJYO9T+8J+o4ho/CJnK/jBy1pWKMYJPvvrpdBCWq3MfzVpXYdahRKHI ypk8m4QlRlbOXWJ3TDd/SKNfSSrWgwRSg7XCjSlR7PNzNFXTULLB34sZhjrN6Q8NQZsZnMNs TX8nlGOVrKolnQPjKCLwCyu8PhllU8OwbSMKskcD1PSkG6h3r0AqzsFNBFcVGkoBEACgAdbR Ck+fsfOVwT8zowMiL3l9a2DP3Eeak23ifdZG+8Avb/SImpv0UMSbRfnw/N81IWwlbjkjbGTu oT37iZHLRwYUFmA8fZX0wNDNKQUUTjN6XalJmvhdz9l71H3WnE0wneEM5ahu5V1L1utUWTyh VUwzX1lwJeV3vyrNgI1kYOaeuNVvq7npNR6t6XxEpqPsNc6O77I12XELic2+36YibyqlTJIQ V1SZEbIy26AbC2zH9WqaKyGyQnr/IPbTJ2Lv0dM3RaXoVf+CeK7gB2B+w1hZummD21c1Laua +VIMPCUQ+EM8W9EtX+0iJXxI+wsztLT6vltQcm+5Q7tY+HFUucizJkAOAz98YFucwKefbkTp eKvCfCwiM1bGatZEFFKIlvJ2QNMQNiUrqJBlW9nZp/k7pbG3oStOjvawD9ZbP9e0fnlWJIsj 6c7pX354Yi7kxIk/6gREidHLLqEb/otuwt1aoMPg97iUgDV5mlNef77lWE8vxmlY0FBWIXuZ yv0XYxf1WF6dRizwFFbxvUZzIJp3spAao7jLsQj1DbD2s5+S1BW09A0mI/1DjB6EhNN+4bDB SJCOv/ReK3tFJXuj/HbyDrOdoMt8aIFbe7YFLEExHpSk+HgN05Lg5TyTro8oW7TSMTk+8a5M kzaH4UGXTTBDP/g5cfL3RFPl79ubXwARAQABwsFfBBgBCAAJBQJXFRpKAhsMAAoJEKqx7BSn lIjvI/8P/jg0jl4Tbvg3B5kT6PxJOXHYu9OoyaHLcay6Cd+ZrOd1VQQCbOcgLFbf4Yr+rE9l mYsY67AUgq2QKmVVbn9pjvGsEaz8UmfDnz5epUhDxC6yRRvY4hreMXZhPZ1pbMa6A0a/WOSt AgFj5V6Z4dXGTM/lNManr0HjXxbUYv2WfbNt3/07Db9T+GZkpUotC6iknsTA4rJi6u2ls0W9 1UIvW4o01vb4nZRCj4rni0g6eWoQCGoVDk/xFfy7ZliR5B+3Z3EWRJcQskip/QAHjbLa3pml xAZ484fVxgeESOoaeC9TiBIp0NfH8akWOI0HpBCiBD5xaCTvR7ujUWMvhsX2n881r/hNlR9g fcE6q00qHSPAEgGr1bnFv74/1vbKtjeXLCcRKk3Ulw0bY1OoDxWQr86T2fZGJ/HIZuVVBf3+ gaYJF92GXFynHnea14nFFuFgOni0Mi1zDxYH/8yGGBXvo14KWd8JOW0NJPaCDFJkdS5hu0VY 7vJwKcyHJGxsCLU+Et0mryX8qZwqibJIzu7kUJQdQDljbRPDFd/xmGUFCQiQAncSilYOcxNU EMVCXPAQTteqkvA+gNqSaK1NM9tY0eQ4iJpo+aoX8HAcn4sZzt2pfUB9vQMTBJ2d4+m/qO6+ cFTAceXmIoFsN8+gFN3i8Is3u12u8xGudcBPvpoy4OoG Message-ID: <31c60529-bdca-8fe2-532d-1adbedbeb774@linaro.org> Date: Mon, 20 Apr 2020 17:18:25 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-25.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Apr 2020 20:18:30 -0000 On 17/04/2020 17:38, Alistair Francis wrote: > On Fri, Apr 17, 2020 at 12:03 PM Adhemerval Zanella via Libc-alpha > wrote: >> >> >> >> On 01/04/2020 13:53, Alistair Francis via Libc-alpha wrote: >>> Remove the sem-pad.h file and instead have architectures override the >>> struct semid_ds via the bits/types/struct_semid_ds.h file. >> >> Ok with the remarks below. >> >> Reviewed-by: Adhemerval Zanella >> >> >>> diff --git a/sysdeps/unix/sysv/linux/bits/types/struct_semid_ds.h b/sysdeps/unix/sysv/linux/bits/types/struct_semid_ds.h >>> index ba0719e77a..659db85db8 100644 >>> --- a/sysdeps/unix/sysv/linux/bits/types/struct_semid_ds.h >>> +++ b/sysdeps/unix/sysv/linux/bits/types/struct_semid_ds.h >>> @@ -20,24 +20,27 @@ >>> # error "Never include directly; use instead." >>> #endif >>> >>> -#if __SEM_PAD_BEFORE_TIME >>> -# define __SEM_PAD_TIME(NAME, RES) \ >>> - __syscall_ulong_t __glibc_reserved ## RES; __time_t NAME >>> -#elif __SEM_PAD_AFTER_TIME >>> -# define __SEM_PAD_TIME(NAME, RES) \ >>> - __time_t NAME; __syscall_ulong_t __glibc_reserved ## RES >>> -#else >>> -# define __SEM_PAD_TIME(NAME, RES) \ >>> - __time_t NAME >>> -#endif >>> - >>> /* Data structure describing a set of semaphores. */ >>> +#if __TIMESIZE == 32 >>> +struct semid_ds >>> +{ >>> + struct ipc_perm sem_perm; /* operation permission struct */ >>> + __time_t sem_otime; /* last semop() time */ >>> + __syscall_ulong_t __glibc_reserved1; >>> + __time_t sem_ctime; /* last time changed by semctl() */ >>> + __syscall_ulong_t __glibc_reserved2; >>> + __syscall_ulong_t sem_nsems; /* number of semaphores in set */ >>> + __syscall_ulong_t __glibc_reserved3; >>> + __syscall_ulong_t __glibc_reserved4; >>> +}; >>> +#else >>> struct semid_ds >>> { >>> struct ipc_perm sem_perm; /* operation permission struct */ >>> - __SEM_PAD_TIME (sem_otime, 1); /* last semop() time */ >>> - __SEM_PAD_TIME (sem_ctime, 2); /* last time changed by semctl() */ >>> + __time_t sem_otime; /* last semop() time */ >>> + __time_t sem_ctime; /* last time changed by semctl() */ >> >> Shouldn't be __time64_t? > > They should be the same as we are outside the __TIMESIZE == 32 define, > time_t just seemed more generic. > > Do you want me to change it? Alright, it we can adjust once 64-bit time_t support is added on SysV.